esphome icon indicating copy to clipboard operation
esphome copied to clipboard

Add support for waveshare epaper 5.83in-bv2

Open jakubcermak opened this issue 2 years ago • 8 comments

What does this implement/fix?

Extension of waveshare_epaper component to support 5.83in-bv2 display

Types of changes

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Other

Pull request in esphome-docs with documentation (if applicable): https://github.com/esphome/esphome-docs/pull/3090

Closes https://github.com/esphome/feature-requests/issues/1477

Test Environment

  • [X] ESP32
  • [ ] ESP32 IDF
  • [ ] ESP8266
  • [ ] RP2040

Example entry for config.yaml:

# Example config.yaml
display:
  - platform: waveshare_epaper
    cs_pin: 5
    dc_pin: 17
    busy_pin: 4
    reset_pin: 16
    model: 5.83in-bv2
    update_interval: 30s
    lambda: |-
      it.print(0, 10, id(def_font), "Hello World!");    

Checklist:

  • [X] The code change is tested and works locally.
  • [ ] Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

jakubcermak avatar Jul 26 '23 19:07 jakubcermak

awesome!

functionpointer avatar Aug 15 '23 12:08 functionpointer

is there anything I should do?

jakubcermak avatar Aug 31 '23 21:08 jakubcermak

Btw I think it fixes https://github.com/esphome/feature-requests/issues/1477

jakubcermak avatar Sep 10 '23 14:09 jakubcermak

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Dec 10 '23 00:12 github-actions[bot]

You may want to merge the dev branch into this periodically. This should keep the bot happy. New integrations regularly take many months to merge.

functionpointer avatar Dec 10 '23 12:12 functionpointer

not stale. However this takes already half a year, is it normal? Or is the project dead and not accepting contributions anymore?

jakubcermak avatar Dec 10 '23 12:12 jakubcermak

Unfortunately it is normal.

ESPHome is quite active and the maintainers are active as well. There are just too many PRs

functionpointer avatar Dec 10 '23 12:12 functionpointer

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

esphome[bot] avatar Dec 21 '23 08:12 esphome[bot]