esphome-docs icon indicating copy to clipboard operation
esphome-docs copied to clipboard

Add rounded backgrounds to feature-icons

Open shvmm opened this issue 8 months ago โ€ข 7 comments

Description:

Add rounded backgrounds to feature icons

Before: 2025-05-28_22-03-36 After: 2025-05-28_22-03-27

2025-05-29_06-52-34

Related issue (if applicable): fixes NONE Pull request in esphome with YAML changes (if applicable): NONE

  • esphome/esphome#<esphome PR number goes here> NONE

Checklist:

  • [ ] I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • [x] I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • [ ] Link added in /components/index.rst when creating new documents for new components or cookbook.

shvmm avatar May 01 '25 08:05 shvmm

Walkthrough

The changes update the .feature-icon CSS class in the _static/index.css file. The modifications include changing the text color, adding a border radius, background color, padding, bottom margin, and aspect ratio to enhance the visual appearance of feature icons. Additionally, a new .feature-icon i selector was added to set display to flex and vertically center its contents. A commented-out line for align-self: flex-start; is included but not activated. No changes were made to the layout, behavior, or any exported or public entities.

Changes

Files Change Summary
CSS Styling Update
_static/index.css
Modified .feature-icon class: changed text color, added border radius, background color, padding, bottom margin, aspect ratio, and a commented-out align-self line; added .feature-icon i selector for flex display and vertical alignment; updated dark mode color to match new color.

Suggested labels

current

Suggested reviewers

  • kbx81

Estimated code review effort

๐ŸŽฏ 1 (Trivial) | โฑ๏ธ ~3 minutes


๐Ÿ“œ Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 3e1f05cb5f5e87f2b1643d377a220eaaaed25b9b and db1467ab7280c9934dac8e851251e3b923506201.

๐Ÿ“’ Files selected for processing (1)
  • _static/index.css (2 hunks)
๐Ÿšง Files skipped from review as they are similar to previous changes (1)
  • _static/index.css
โœจ Finishing Touches
๐Ÿงช Generate unit tests
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share
๐Ÿชง Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 01 '25 08:05 coderabbitai[bot]

Deploy Preview for esphome ready!

Name Link
Latest commit db1467ab7280c9934dac8e851251e3b923506201
Latest deploy log https://app.netlify.com/projects/esphome/deploys/684724566e8107000801b6b3
Deploy Preview https://deploy-preview-4867--esphome.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar May 01 '25 08:05 netlify[bot]

@shvmm, is it possible to get the icon circles to be round. The padding is messing with it I think. Adding a fixed width/height or using aspect-ratio should work

mrdarrengriffin avatar May 28 '25 10:05 mrdarrengriffin

Personally, I prefer the current cleaner look without the icon backgrounds. The background makes the icons harder to see due to the similar colors. It also highlights the icons too much (which I don't think they need, since they are not interactive).

Still, if the backgrounds are added then they should be consistent circles.

abmantis avatar May 28 '25 10:05 abmantis

Personally, I prefer the current cleaner look without the icon backgrounds. The background makes the icons harder to see due to the similar colors. It also highlights the icons too much (which I don't think they need, since they are not interactive).

Still, if the backgrounds are added then they should be consistent circles.

You are correct. Even to me, its look in dark mode isn't even close to how good it looks in light mode.

@shvmm, is it possible to get the icon circles to be round. The padding is messing with it I think. Adding a fixed width/height or using aspect-ratio should work

Thanks. Will try the aspect-ratio approach

shvmm avatar May 28 '25 14:05 shvmm

The preview looks better, just make the .feature-icon i have display: flex; align-items: center; to ensure they are aligned correctly

mrdarrengriffin avatar Jun 09 '25 09:06 mrdarrengriffin

The preview looks better, just make the .feature-icon i have display: flex; align-items: center; to ensure they are aligned correctly

Done. Thanks for the tip. I have also tried fixing dark mode colors

Looks mostly good for now.

shvmm avatar Jun 09 '25 18:06 shvmm

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Aug 09 '25 02:08 github-actions[bot]

I personally prefer it without the background. But best wait for the new site and see what you think.

clydebarrow avatar Aug 13 '25 00:08 clydebarrow

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Nov 30 '25 02:11 github-actions[bot]