esphome-docs icon indicating copy to clipboard operation
esphome-docs copied to clipboard

LD2410s Radar Sensor by NovakIrs

Open NovakIrs opened this issue 8 months ago • 6 comments

Description:

Related issue (if applicable): fixes https://github.com/esphome/feature-requests/issues/2872

Pull request in esphome with YAML changes (if applicable): https://github.com/esphome/esphome/pull/8486

  • esphome/esphome#<8486>

Checklist:

  • [X] I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • [ ] I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • [X] Link added in /components/index.rst when creating new documents for new components or cookbook.

NovakIrs avatar Apr 06 '25 08:04 NovakIrs

[!WARNING]

Rate limit exceeded

@jesserockz has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 27 minutes and 20 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 4de937769a28e385202c4f160a441b7b7e12dbb1 and d464ab8c3ac6850ceef25d2bff7f3e6e7070e895.

⛔ Files ignored due to path filters (2)
  • components/sensor/images/ld2410s.png is excluded by !**/*.png
  • images/ld2410s.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • components/index.rst (2 hunks)

Walkthrough

This pull request adds documentation for the new LD2410s sensor. It introduces an entry in the main documentation index under the "Motion" and "Presence Detection" sections and provides a separate, comprehensive file detailing configuration options, parameters, and examples specific to the LD2410s sensor integration.

Changes

Files Change Summary
components/index.rst, components/sensor/ld2410s.rst Added documentation for the LD2410s sensor. The index file now includes entries for the sensor under "Motion" and "Presence Detection," while the new file explains configuration parameters such as UART settings, binary sensors, sensors, text sensors, numbers, buttons, and select options.

Assessment against linked issues

Objective Addressed Explanation
Support Hi-Link LD2410S (HLK-LD2410S) 24GHz Ultra Low Power Radar Sensor (#2872)

Suggested labels

next

Suggested reviewers

  • nagyrobi
  • jesserockz

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Apr 06 '25 08:04 coderabbitai[bot]

Deploy Preview for esphome ready!

Name Link
Latest commit 473abd35fb5b2dc57577d5d4577194a0f3cdcfa2
Latest deploy log https://app.netlify.com/projects/esphome/deploys/686139f518c0d00008980823
Deploy Preview https://deploy-preview-4798--esphome.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Apr 06 '25 08:04 netlify[bot]

Is this part of ESPHome yet? I have an LD2410s ready to roll. Thanks 😄

ventrebleu avatar Apr 21 '25 21:04 ventrebleu

Is this part of ESPHome yet?

I have an LD2410s ready to roll.

Thanks 😄

Hi, My pool request still waits for official review but it is possible to test and use it from my repository or from my pool request. I can help you with that. And if you do, please send me default calibration of your ld2410s before tweaking, all three lines of numbers, threshold, hold and SNR. My calibration was modified before I had means to read it so my "factory default" can be improved.

NovakIrs avatar May 14 '25 04:05 NovakIrs

Is this part of ESPHome yet? I have an LD2410s ready to roll. Thanks 😄

Hi, My pool request still waits for official review but it is possible to test and use it from my repository or from my pool request. I can help you with that. And if you do, please send me default calibration of your ld2410s before tweaking, all three lines of numbers, threshold, hold and SNR. My calibration was modified before I had means to read it so my "factory default" can be improved.

I'm struggling to make it work. Details here if you can help: https://community.home-assistant.io/t/esphome-how-to-use-the-hlk-ld2410s/736597/22 Thanks! 🙏🏼

ventrebleu avatar May 22 '25 23:05 ventrebleu

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

esphome[bot] avatar May 28 '25 05:05 esphome[bot]