esphome-docs icon indicating copy to clipboard operation
esphome-docs copied to clipboard

Request to add CrowPanel 4.3, 5.0, and 7.0 - HMI ESP32 Display RGB TFT LCD Touch Screen Development Boards

Open Elecrow-RD opened this issue 1 year ago • 2 comments

Reference Website for Materials: 4.3:https://www.elecrow.com/esp32-display-4-3-inch-hmi-display-rgb-tft-lcd-touch-screen.html 5.0:https://www.elecrow.com/esp32-display-5-inch-hmi-display-rgb-tft-lcd-touch-screen-support-lvgl.html 7.0:https://www.elecrow.com/esp32-display-7-inch-hmi-display-rgb-tft-lcd-touch-screen-support-lvgl.html

Elecrow-RD avatar Sep 14 '24 10:09 Elecrow-RD

Walkthrough

The pull request introduces updates to the documentation for the RPI_DPI_RGB Display Driver, specifically adding configurations for three new CrowPanel display models: a 4.3" 480x272 Touch Display, a 5.0" 800x480 Touch Display, and a 7.0" 800x480 Touch Display. Each model includes detailed YAML configuration examples outlining parameters such as dimensions, pin assignments, and color settings, along with images for better visual representation.

Changes

Files Change Summary
components/display/rpi_dpi_rgb.rst Added configurations for CrowPanel 4.3" 480x272 Touch Display, 5.0" 800x480 Touch Display, and 7.0" 800x480 Touch Display, including YAML examples and images.

[!WARNING]

Rate limit exceeded

@ssieb has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 30 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 7174238772bf02abb3cede877c5805aad29027c4 and 90dbcdc117f0862a9eb16498ec812b3223af515e.


📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 7174238772bf02abb3cede877c5805aad29027c4 and 90dbcdc117f0862a9eb16498ec812b3223af515e.

📒 Files selected for processing (1)
  • components/display/rpi_dpi_rgb.rst (3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
components/display/rpi_dpi_rgb.rst (1)

Pattern **: - Do not generate or add any sequence diagrams

🔇 Additional comments (4)
components/display/rpi_dpi_rgb.rst (4)

19-21: LGTM: Model list additions are properly formatted

The new CrowPanel display models are correctly added to the supported displays list, maintaining consistency with existing entries.


279-314: :warning: Potential issue

Add missing timing parameters for 5.0" display

The configuration is missing crucial timing parameters that are present in the 4.3" configuration:

  • hsync_back_porch
  • hsync_front_porch
  • hsync_pulse_width
  • vsync_back_porch
  • vsync_front_porch
  • vsync_pulse_width

These parameters are essential for proper display initialization. Please add them based on the manufacturer specifications.


34-50: Verify image files exist in the repository

The figure references are properly formatted, but we should verify that the referenced image files exist.

✅ Verification successful

All referenced image files are present in the correct location

All three image files are found in the expected components/display/images/ directory:

  • CrowPanel_4.3-HMI_ESP32_Display_480x272_RGB.jpg
  • CrowPanel_5.0-HMI_ESP32_Display_800x480_RGB.jpg
  • CrowPanel_7.0-HMI_ESP32_Display_800x480_RGB.jpg
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if the referenced image files exist in the images directory

for img in "CrowPanel_4.3-HMI_ESP32_Display_480x272_RGB.jpg" "CrowPanel_5.0-HMI_ESP32_Display_800x480_RGB.jpg" "CrowPanel_7.0-HMI_ESP32_Display_800x480_RGB.jpg"; do
  if ! fd "$img" components/display/images/; then
    echo "Missing image file: $img"
  fi
done

Length of output: 950


320-354: :warning: Potential issue

Add missing timing parameters and verify pin assignments for 7.0" display

  1. The configuration is missing the same timing parameters as the 5.0" display.

  2. The pin assignments differ significantly from other models. While this might be intentional due to hardware differences, please verify these assignments against the manufacturer's specifications.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Sep 14 '24 10:09 coderabbitai[bot]

Deploy Preview for esphome ready!

Name Link
Latest commit 90dbcdc117f0862a9eb16498ec812b3223af515e
Latest deploy log https://app.netlify.com/sites/esphome/deploys/673e9d77c2b293000831d84e
Deploy Preview https://deploy-preview-4248--esphome.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 14 '24 10:09 netlify[bot]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Nov 14 '24 01:11 github-actions[bot]

@Elecrow-RD please file a PR for https://devices.esphome.io/. That's where integrated device configs go. https://devices.esphome.io/adding-devices Someone already added the 5in one there: https://github.com/esphome/esphome-devices/pull/812

ssieb avatar Nov 21 '24 08:11 ssieb