esphome-docs icon indicating copy to clipboard operation
esphome-docs copied to clipboard

Add Lilygo T-Encoder PRO Display to qspi_amoled

Open mrbubble62 opened this issue 1 year ago â€ĸ 7 comments

Description:

Tested and working with Lilygo T-Encoder PRO display even though the driver chip is SH8601.

Related issue (if applicable): fixes

Pull request in esphome with YAML changes (if applicable): esphome/esphome#<esphome PR number goes here>

Checklist:

  • [ ] I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • [ x] I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • [ ] Link added in /index.rst when creating new documents for new components or cookbook.

mrbubble62 avatar Jul 25 '24 18:07 mrbubble62

Walkthrough

The documentation for the QSPI AMOLED driver has been updated to include the "Lilygo T-Encoder PRO" display model. This enhancement improves compatibility information by adding the model to the list of tested displays. Additionally, a new section provides detailed YAML configuration settings for the display, covering SPI and display parameters. A visual representation of the display is also included, facilitating user reference and improving the overall documentation structure.

Changes

Files Change Summary
components/display/qspi_amoled.rst Added new section, figure reference, and YAML configuration block for the "Lilygo T-Encoder PRO" display model.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

â¤ī¸ Share
đŸĒ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jul 25 '24 18:07 coderabbitai[bot]

Deploy Preview for esphome ready!

Name Link
Latest commit 820afc7e2267f05e159f4f87848d1f99646b1796
Latest deploy log https://app.netlify.com/sites/esphome/deploys/66ca5b07b6d6780008839cb4
Deploy Preview https://deploy-preview-4082--esphome.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 25 '24 18:07 netlify[bot]

Thanks for this, even if it's not merged I know the screen works. Did you manage to get the touchscreen working as well?

dgaust avatar Aug 03 '24 04:08 dgaust

Can you share a full working yaml config for this? I tried adding this along with a simple lambda to draw a line/circle/etc. but couldn't get anything to show up.

pzich avatar Aug 08 '24 04:08 pzich

Can you share a full working yaml config for this? I tried adding this along with a simple lambda to draw a line/circle/etc. but couldn't get anything to show up.

This is using the preview LVGL but should get you going

https://github.com/dgaust/esphome_files/blob/main/lilygo-encoder-pro

note: even though there's a reference to a touchscreen in that yaml it's just because I need a touch screen in there - it doesn't actually work.

dgaust avatar Aug 08 '24 05:08 dgaust

Thanks for sharing, but unfortunately I can't seem to get that one to work either, or even an extremely minimal version of that (without any spi config, etc.):

esphome:
  name: lily
  friendly_name: lily

esp32:
  board: esp32-s3-devkitc-1
  framework:
    type: esp-idf

logger:

wifi:
  ssid: !secret wifi_ssid
  password: !secret wifi_password

psram:
  mode: octal
  speed: 80MHz

I always seem to end up with rst:0x7 (TG0WDT_SYS_RST),boot:0x2a (SPI_FAST_FLASH_BOOT) â˜šī¸

Strangely, an arduino framework type manages to run, connect to wifi, control the buzzer, etc. but the quad SPI isn't available there.

pzich avatar Aug 08 '24 06:08 pzich

It turns out the issue is that I needed to specify the flash mode

esphome:
  platformio_options:
    board_build.flash_mode: dio

pzich avatar Aug 08 '24 23:08 pzich

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Oct 24 '24 02:10 github-actions[bot]