esphome-docs icon indicating copy to clipboard operation
esphome-docs copied to clipboard

Update ssd1306.rst

Open MauroMP1 opened this issue 5 months ago ā€¢ 7 comments

Invertir los pines de i2C, scl es D1 y sda es D2

Description:

Related issue (if applicable): fixes

Pull request in esphome with YAML changes (if applicable): esphome/esphome#<esphome PR number goes here>

Checklist:

  • [ ] I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • [x] I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • [ ] Link added in /index.rst when creating new documents for new components or cookbook.

MauroMP1 avatar Feb 18 '24 04:02 MauroMP1

Deploy Preview for esphome ready!

Name Link
Latest commit 46419f8ac0a69acd72865ff2ef9eb7afe5781594
Latest deploy log https://app.netlify.com/sites/esphome/deploys/65d18127e2099c000896b8a6
Deploy Preview https://deploy-preview-3611--esphome.netlify.app/components/display/ssd1306
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 18 '24 04:02 netlify[bot]

It would be nice if you would write your description in English, since this is the project's language.

Nevertheless, I happen to understand Spanish as well, and, at least according to the documentation above the part you propose to change, the description explicitly mentions "Connect D2 to the SCL and D1 to the SDA", so the documentation is already good as it is now.

guillempages avatar Mar 13 '24 19:03 guillempages

Hello I will remember this for the next time. (It would be nice if you would write your description in English, since this is the project's language.)

Nevertheless, I happen to understand Spanish as well, and, at least according to the documentation above the part you propose to change, the description explicitly mentions "Connect D2 to the SCL and D1 to the SDA", so the documentation is already good as it is now.

In the moment when i suggest this change, the documentation was D1 to SCL and D2 to SDA, then 4 or 5 days it change, i assumed that this suggestion worked, but i'nt understand well how work git in this cases. Sorry for the complications and thanks.

M4ur0MP avatar Mar 15 '24 10:03 M4ur0MP

Sorry, but I saw the site again and it is inverted again, in the previous answer I based myself on your answer, but what you suggested is the opposite, in my case I tested the LCD with an esp8266 nodemcu which has the i2c, SCL=>D1 , SDA=>D2, in the example documentation this is inverted, which caused complications for me until I realized that they were inverted, even in the esp32 they are not even close, I suppose the example is with the esp8266. Sorry for the complications and thank you Greetings

M4ur0MP avatar Mar 15 '24 10:03 M4ur0MP

It's inverted w.r.t. the nodeMCU default pinout, as you mention. This has not changed.

What I was referring to is the text: "Connect D2 to the SCL pin you chose for the IĀ²C Bus, and connect D1 to the SDA pin." which is in the same page; just above the example configuration entry.

If you follow those instructions, regardless of the "default" I2C pins on the nodeMCU, the example configuration is right. So your change would make this inconsistent. AFAIK, the esp8266 does not have hardware specific I2C pins, so it actually does not make any difference if you use D! and D2 as the pinout says, as the ESPHome documentation says or you pick any other two pins.

Nevertheless, I agree that if there is a "preferred" standard (i.e. the nodeMCU pinout documents), it would be better to use that. Your change is not enough for that though; please also update the "Connect ..." text above so that it is then kept consistent with the example.

guillempages avatar Mar 16 '24 21:03 guillempages

I don't think there's such a "preferred" standard. Too many boards with too many proprietary "standards". It's no standard, just more and more confusion.

The preferred way is to use normal GPIOxx naming, as it's board-independent. Then everyone can look up its own GPIOs depending on the board he/she has.

nagyrobi avatar Mar 16 '24 21:03 nagyrobi

guillempages it's correct how you says, my change was incomplete, sorry, i will try pay more atenttion I think, seeing the boards most used, make the change how says "nagyrobi", and more because in the code in the most cases i think is used nomenclature GPIO and not number of pin i2c: sda: GPIO5 scl: GPIO4 Thanks Greetings

M4ur0MP avatar Mar 16 '24 21:03 M4ur0MP