esphome-docs icon indicating copy to clipboard operation
esphome-docs copied to clipboard

Shelly 2.5 config for ADE7953

Open rfpronk opened this issue 3 years ago • 7 comments

Description:

Add Shelly 2.5 config for ADE7953

Related issue (if applicable): n.a.

Pull request in esphome with YAML changes (if applicable): n.a.

Checklist:

  • [x] Branch: next is for changes and new documentation that will go public with the next ESPHome release. Fixes, changes and adjustments for the current release should be created against current.
  • [x] ~Link added in /index.rst when creating new documents for new components or cookbook.~ n.a.

rfpronk avatar Sep 11 '21 09:09 rfpronk

@oxan Thanks for the review. I added a commit to process your comments.

rfpronk avatar Sep 11 '21 14:09 rfpronk

There's still some substitutions remaining, looks good otherwise.

oxan avatar Sep 11 '21 14:09 oxan

There's still some substitutions remaining, looks good otherwise.

Sorry about that

rfpronk avatar Sep 11 '21 15:09 rfpronk

Actually, is there any reason you moved the config block for the NTC sensor?

oxan avatar Sep 11 '21 15:09 oxan

Actually, is there any reason you moved the config block for the NTC sensor?

I've removed that as it has nothing to do with the ADE7953 sensor (which this doc is about), but if you prefer we can keep it in there.

rfpronk avatar Sep 11 '21 17:09 rfpronk

Fair enough, that makes sense.

oxan avatar Sep 11 '21 17:09 oxan

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Nov 11 '21 01:11 github-actions[bot]