Enable flashing from GitHub PRs?

[nicpottier]

Hi all, love this so much as a great way to enable more people to share their work.

I've been setting up a toolchain for a new project using platformio and github actions and it is pretty great to be able to get built firmwares in pull requests, example here: https://github.com/nicpottier/gnat/pull/1

The next most amazing thing would be able to just click a button to trigger esb-web-tools to install said firmware. That would make collaboration and reviews of PRs dead easy. It feels very close to allow an action to comment on a PR with the appropriate link to make that happen, but I'm not seeing examples of this..

I'm guessing there's a reason this isn't possible (CORS?) but couldn't find an issue about it (searching for anything github related in github issues is a bit hopeless)

If nothing else maybe this issue will come up for someone else with the same question.

Thanks for all the hard work!

[balloob]

Yep, it's CORS 👍

Uploading firmware to flash does work; which we did for example here https://web.esphome.io/ (it's not using ESP Web Tools)

We have our own ESP Web Tools action that we use to maintain websites with specialized ESPHome configurations https://github.com/esphome/workflows

[nicpottier]

Thanks, that makes sense. Makes me ponder setting up a tiny site that would enable this for ESP projects..

That said, I first need to get this working for the simple case. I'm trying to work out how to get the right manifest file built, can you point me in the right direction as to where you are generating that manifest for your own github workflows? I tried poking around a bit at your workflows and got lost in docker land.

[nicpottier]

Closing this.. I ended up figuring out that on ESP32 boards these seem to be mostly the same for ESP32 boards. Thanks!