Arduino icon indicating copy to clipboard operation
Arduino copied to clipboard

Published 20 hours ago • verified publisher icon esp8266

Add move constructor/assignment to BearSSL helpers

Open earlephilhower opened this issue 2 years ago • 3 comments

Fixes #8522

earlephilhower avatar Mar 29 '22 20:03 earlephilhower

I should also protect the SigningVerifier, so to draft for now.

earlephilhower avatar Mar 29 '22 20:03 earlephilhower

nit: unique_ptr will help, since we don't allow copies anyway and it handles free() and gets zeroed when when move happens

mcspr avatar Mar 29 '22 23:03 mcspr

idk what to answer for review, but 'it does not look simplified' :) given the stability of the existing code (as it was the main argument from Matrix), we should probably rethink the overall structure instead of pushing certain features to the current one that make it more complicated instead of the opposite

mcspr avatar Apr 07 '22 08:04 mcspr