Backport getLocalTime from ESP32

[h1aji]

Was trying to port this code from ESP32, but found that getLocalTime doesnt exist. Is there a replacement?

void gettime()
{
  static int16_t delaycount = 0 ;                         // To reduce number of NTP requests
  static int16_t retrycount = 100 ;

  if ( timeinfo.tm_year )                                 // Legal time found?
  {
    sprintf ( timetxt, "%02d:%02d:%02d",                  // Yes, format to a string
              timeinfo.tm_hour,
              timeinfo.tm_min,
              timeinfo.tm_sec ) ;
  }
  if ( --delaycount <= 0 )                                // Sync every few hours
  {
    delaycount = 7200 ;                                   // Reset counter
    if ( timeinfo.tm_year )                               // Legal time found?
    {
      dbgprint ( "Sync TOD, old value is %s", timetxt ) ;
    }
    dbgprint ( "Sync TOD" ) ;
    if ( !getLocalTime ( &timeinfo, 5000 ) )              // Read from NTP server
    {
      dbgprint ( "Failed to obtain time!" ) ;             // Error
      timeinfo.tm_year = 0 ;                              // Set current time to illegal
      if ( retrycount )                                   // Give up syncing?
      {
        retrycount-- ;                                    // No try again
        delaycount = 5 ;                                  // Retry after 5 seconds
      }
    }
    else
    {
      sprintf ( timetxt, "%02d:%02d:%02d",                // Format new time to a string
                timeinfo.tm_hour,
                timeinfo.tm_min,
                timeinfo.tm_sec ) ;
      dbgprint ( "Sync TOD, new value is %s", timetxt ) ;
    }
  }
}

Or is there any chance to add this from esp32-hal-time.c

bool getLocalTime(struct tm * info, uint32_t ms)
{
    uint32_t start = millis();
    time_t now;
    while((millis()-start) <= ms) {
        time(&now);
        localtime_r(&now, info);
        if(info->tm_year > (2016 - 1900)){
            return true;
        }
        delay(10);
    }
    return false;
}

[d-a-v]

Why don't you directly use localtime() ?

Anyway if you think this core should get bool getLocalTime(struct tm * info, uint32_t ms) for better inter-operability, then your PR is welcome.

[h1aji]

Can you give me a tip? do you mean if ( !localtime ( &timeinfo ) ) ?

[d-a-v]

Yes. There is an example. I guess you can also simply copy-paste and use your above getLocalTime().

[h1aji]

Tried localtime_r() but it shows incorrect time. Anyway, its good to have this function for ESP8266 available. Created PR, please review here https://github.com/esp8266/Arduino/pull/8407 Thanks

[h1aji]

new PR here https://github.com/esp8266/Arduino/pull/8407