rust-build icon indicating copy to clipboard operation
rust-build copied to clipboard

Builds with nightly are failing - display information about working version on GH page

Open georgik opened this issue 3 years ago • 5 comments

Build for C3 is failing with latest nightly. It would be very useful to be explicit about which version of nightly is working. The last working version known to me is +nightly-2022-08-15

georgik avatar Oct 17 '22 11:10 georgik

The CI is passing successfully with all 3 latest nightly, which means that the esp-template project is building successfully with that nightly version: https://github.com/esp-rs/rust-build/actions/runs/3263489115/jobs/5362430878#step:5:21

How is latest nightly failing for you?

SergioGasquez avatar Oct 17 '22 11:10 SergioGasquez

Simulated problem with Windows 11

error: cannot find attribute `default_method_body_is_const` in this scope
   --> C:\Users\User\.rustup\toolchains\nightly-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\core\src\clone.rs:132:7
    |
132 |     #[default_method_body_is_const]
    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: could not compile `core` due to 6 previous errors
warning: build failed, waiting for other jobs to finish...
PS C:\projects\esp-hal\esp32c3-hal> rustc --version
rustc 1.66.0-nightly (dcb376115 2022-10-20)

georgik avatar Oct 24 '22 07:10 georgik

I assume you were building one of the esp-hal examples, right? Can you try building the following project (which is the one that is being built in the CI) with the same toolchain?

cargo generate --git https://github.com/esp-rs/esp-template --name test --vcs none --silent -d mcu=esp32c3 -d devcontainer=false -d alloc=false

I would confirm that is the toolchain on Windows that is failing.

SergioGasquez avatar Oct 24 '22 07:10 SergioGasquez

Command: cargo build --release

error: cannot find attribute `default_method_body_is_const` in this scope
   --> C:\Users\User\.rustup\toolchains\nightly-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\core\src\clone.rs:132:7
    |
132 |     #[default_method_body_is_const]
    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Command: cargo "+nightly-2022-08-15" build --release

   Compiling test v0.1.0 (C:\projects\test)
    Finished release [optimized] target(s) in 35.82s

georgik avatar Oct 24 '22 12:10 georgik

I updated the nightly CI check action on a branch and I was able to successfully build esp-template project for esp32c3 in Windows, see: https://github.com/esp-rs/rust-build/actions/runs/3337353944/jobs/5523591802

SergioGasquez avatar Nov 02 '22 08:11 SergioGasquez