esp-idf-svc icon indicating copy to clipboard operation
esp-idf-svc copied to clipboard

Published 20 hours ago • verified publisher icon esp-rs

WPS regression: Option::unwrap on event payload

Open torkleyy opened this issue 1 year ago • 3 comments

WPS no longer works in the latest release, it regressed in commit 29ce820f5012d70c5853c0c646efd7664658cd44

Line 1901 in that commit is problematic, as it assumes an event payload is present in any case.

In case there is just a single WPS config, the event payload will be empty and instead the wifi config is updated by the driver (very curious behavior in my opinion, but that's why we had the check in there). Thus, it will panic due to the unwrap.

torkleyy avatar Mar 04 '24 14:03 torkleyy

thanks for reporting, can you try to create a PR fixing it?

Vollbrecht avatar Mar 04 '24 14:03 Vollbrecht

Yes. Maybe we can merge my open PR https://github.com/esp-rs/esp-idf-svc/pull/368 in the meantime so I can easily test it within my application :D

torkleyy avatar Mar 04 '24 14:03 torkleyy

Hey, I did hit this issue today, any update on this? I see #379 being a fix for this issue, could we get it merged?

shekohex avatar May 09 '24 18:05 shekohex

#379 was merged

Vollbrecht avatar Jun 21 '24 08:06 Vollbrecht