esp-idf-svc
esp-idf-svc copied to clipboard
esp-rs
Add sni support for https
Depends on ~~https://github.com/esp-rs/esp-idf-svc/pull/136~~ and https://github.com/espressif/esp-idf/pull/9833.
Fixes build issues (field renames) on idf master
Depends on #136 Isn't this the other way around? As in #137 depending on this one?
Also, shouldn't we wait until https://github.com/espressif/esp-idf/pull/9833 is merged first?
No and yes :)
#136 adds the https server itself, and this pr extends that with support for sni. This pr is actually based on that pr, and is a superset of that one.
Yes, espressif/esp-idf#9833 needs to be merged before this can work, but I wanted this opened so it can be reviewed and used by others looking for sni support.
rebased on the merge https server. It fixes a few issues with build on idf master as well.
@axos88 I have not forgotten about this one, but I hope you don't mind I'll review & merge this post-release of the current esp-idf-svc crate. Release is due in a matter of a couple of days actually. We'll issue a subsequent incremental release with your changes then.
Thanks @ivmarkov, the upstream changes to esp IDF have been merged, but as I started to use the changes here, i realized a lot of stuff need to be done in a different/better way. I'll need to update this pr before it's worth to spend time reviewing it
Thanks @ivmarkov, the upstream changes to esp IDF have been merged, but as I started to use the changes here, i realized a lot of stuff need to be done in a different/better way. I'll need to update this pr before it's worth to spend time reviewing it
Np, I'll wait.