esp-idf-hal
esp-idf-hal copied to clipboard
esp-rs
spi/adc_st7789_example
@monacoprinsen I think it would be great to have an ADC example! Ideally though, examples should be tiny and targeted to demoing just one feature. So I think it would actually be beneficial if you remove the st7789 aspects from this example. (Or create another example, that is only demonstrating how to write on an st7789 screen.)
The other thing is, would it be possible to update the example so that it follows the latest changes to the master branch? There were quite a few of those, but the ADC driver is mostly intact, modulo some renames here and there?
@ivmarkov thanks for the input. I have added 3 examples: Simple adc example St7789 adc example St7789 spi example
If you prefer that I remove the St7789 examples I can do that.
Should work to update to the latest branch, will do that.
@monacoprinsen The "St7789 adc" example we should remove, the other two we keep.
Can you please also update the examples to be compatible with latest master? They are currently failing the cargo fmt but I looked briefly at them, and they are not based on master.
@ivmarkov now it should be up to date.
Can you make sure that the CI checks pass successfully on your changes? I.e. cargo fmt, cargo clippy and the subsequent actual build. Otherwise, merging your changes will immediately break CI and I need to immediately follow up with fixes of your just merged code.
@ivmarkov thanks, adjusted it! Sorry for the mess, hopefully next contribution will be a little cleaner.