esp-hal icon indicating copy to clipboard operation
esp-hal copied to clipboard

Implement Digest traits for SHA

Open Natureshadow opened this issue 2 years ago • 1 comments

In order to use the hardware-accelerated SHA on ESP32 with external code that accepts implementations of the digest traits, it would be helpful to implement those on the Sha struct.

The implementation should probably be behind a digest feature flag in order to avoid the dependency if not needed.

Natureshadow avatar Nov 14 '23 21:11 Natureshadow

+1 - we should implement the crypto traits for all crypto-accelerators: https://github.com/RustCrypto/traits

but we will need to do what is worked on in https://github.com/esp-rs/esp-hal/pull/866 for them first

bjoernQ avatar Nov 15 '23 08:11 bjoernQ