esp-hal icon indicating copy to clipboard operation
esp-hal copied to clipboard

Add sdm

Open katyo opened this issue 1 year ago • 1 comments

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request. To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • [x] I have updated existing examples or added new ones (if applicable).
  • [x] I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • [x] My changes were added to the CHANGELOG.md in the proper section.
  • [ ] I have added necessary changes to user code to the Migration Guide.
  • [ ] My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

Almost all ESP SoCs has Sigma-delta modulation periphery which can be used as an alternative for DAC.

ESP32 SoC Number of SigmaDelta channels
ESP32 8
ESP32-S2 8
ESP32-S3 8
ESP32-C3 4
ESP32-C6 4
ESP32-H2 4

SDM on Wikipedia IDF API documentation

Testing

Describe how you tested your changes.

katyo avatar Oct 20 '24 22:10 katyo

@bugadani @Dominaezzz I have rework API just now but I still have some doubt about the new design.

katyo avatar Oct 21 '24 18:10 katyo

@katyo thanks for the PR! I'd love to see this finished, are you planning to revisit this anytime soon?

MabezDev avatar Jan 21 '25 16:01 MabezDev

@katyo thanks for the PR! I'd love to see this finished, are you planning to revisit this anytime soon?

Yes, but I'm a bit busy at work right now.

katyo avatar Jan 22 '25 18:01 katyo

GPIO, and the hal has changed a lot. I would love to see this added, but I think a new PR is probably the best bet given the time frame this has been open.

Closing.

MabezDev avatar Jul 01 '25 14:07 MabezDev