esp-hal icon indicating copy to clipboard operation
esp-hal copied to clipboard

Add option to disable waiti

Open bugadani opened this issue 1 year ago • 2 comments

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request. To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • [ ] I have updated existing examples or added new ones (if applicable).
  • [x] I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • [x] My changes were added to the CHANGELOG.md in the proper section.
  • [x] I have added necessary changes to user code to the Migration Guide.
  • [x] My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

Apparently sometimes it's better to not sleep as it may cause increased noise in analog circuitry.

While it's possible to work around the issue by defining idle tasks, continuous polling might be slightly better in terms of latency.

Alternatives:

  • idle task
  • new, simpler thread-mode executor

bugadani avatar Oct 10 '24 12:10 bugadani

I'm somewhat hesitant here, I think this config needs much more explanation, but I'm not sure where to add it:

  • When to use it
  • When NOT to use it, and what alternatives can be considered

bugadani avatar Oct 14 '24 09:10 bugadani

I'm considering this ready. Unless someone has objections, given the two approvals I'll merge this early next week.

bugadani avatar Oct 25 '24 16:10 bugadani