esp-hal icon indicating copy to clipboard operation
esp-hal copied to clipboard
verified publisher icon esp-rs

pub UartRx read_byte

Open nan-mu opened this issue 1 year ago • 2 comments

Detail in https://github.com/esp-rs/esp-hal/issues/1547

nan-mu avatar May 09 '24 14:05 nan-mu

Thanks! Making read_byte public is fine but there are a few problems with this PR

  • public functions should include API docs
  • this adds a changelog in the root - the changelog entry should go into esp-hal/CHANGELOG.md
  • code formatting

bjoernQ avatar May 10 '24 04:05 bjoernQ

The issue has been resolved. I hadn't previously worked with these tools, so I'm thankful; I've learned a lot.

nan-mu avatar May 10 '24 13:05 nan-mu