esp-hal icon indicating copy to clipboard operation
esp-hal copied to clipboard

Published 20 hours ago • verified publisher icon esp-rs

Update `CONTRIBUTING.md`

Open playfulFence opened this issue 11 months ago • 4 comments

closes #1225

playfulFence avatar Mar 19 '24 12:03 playfulFence

(Sorry I'm reading some material relating to contributing guides, will do a proper review within the next few business days)

jessebraham avatar Mar 20 '24 23:03 jessebraham

Sorry for not getting to this, had a lot on my plate.

I think we should meet as a team to discuss how best to move forward with this. I think there is a fair bit of information that should ultimately be included in CONTRBUTING.md (and/or other documents), so it'd be nice to come up with a bit of a game plan first.

CC @MabezDev

jessebraham avatar Apr 11 '24 13:04 jessebraham

Now that we have the xtask, I think we should also document some do's and don't of how to use it. For example we should state that all xtask commands should be run from the root of the project, not in a sub project.

MabezDev avatar Apr 27 '24 14:04 MabezDev

@MabezDev, agree! Maybe let's discuss this topic on a next meeting(/when most of us won't have a vacation 😄)? Just to put this matter to rest.

cc: @jessebraham (as you've had some thoughts and suggestions on this)

upd: Also worth mentioning is the update to the HIL tests in case related API was changed

playfulFence avatar Apr 27 '24 14:04 playfulFence