react-timeseries-charts icon indicating copy to clipboard operation
react-timeseries-charts copied to clipboard

Published 20 hours ago • verified publisher icon esnet

Do Not Merge - Charts typescript version

Open sartaj10 opened this issue 6 years ago • 8 comments

Still to fix

Website

  • [ ] Website to typescript
  • [ ] All examples to typescript to verify

React-Charts

React-Axis

  • [ ] Axis ticks & tickCount logic

Examples

Cycling

  • [ ] Fix pond errors

DDoS

  • [ ] Clicking on Legend leads to "Uncaught Error: Unable to find node on an unmounted component"

sartaj10 avatar May 23 '18 21:05 sartaj10

Can I assume from this that you are converting the code base to TypeScript (🎉 )? If so, any time line? I'd be happy to help you test alpha/beta releases.

xogeny avatar Jun 05 '18 17:06 xogeny

@xogeny Yes, that is exactly what's happening. It'll work perfectly with the typescript pond.js library as well. We're almost there. Need to fix a few code issues and rebuild the website with the typescript docs. However, don't have a proper timeline yet. The plan is to do this ASAP

sartaj10 avatar Jun 05 '18 18:06 sartaj10

🎉

On Jun 5, 2018, at 1:05 PM, Sartaj Singh Baveja [email protected] wrote:

@xogeny https://github.com/xogeny Yes, that is exactly what's happening. It'll work perfectly with the typescript pond.js library as well. We're almost there. Need to fix a few code issues and rebuild the website with the typescript docs. However, don't have a proper timeline yet. The plan is to do this ASAP

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/esnet/react-timeseries-charts/pull/268#issuecomment-394805860, or mute the thread https://github.com/notifications/unsubscribe-auth/AABqnNDMD_xWesOtLGMsAEMdMeUA-Giyks5t5sh3gaJpZM4ULOS7.

camflan avatar Jun 05 '18 18:06 camflan

Progress :

screen shot 2018-06-09 at 6 14 31 pm

sartaj10 avatar Jun 10 '18 01:06 sartaj10

Is this work still going on?

xogeny avatar Sep 09 '18 21:09 xogeny

@xogeny It's still a thing, but a slow moving one unfortunately. Most of this is completed but there's still some issues running some of the old examples.

pjm17971 avatar Sep 10 '18 16:09 pjm17971

came across this lib and am interested in using it in a TS project. Anything outside contributors can do to get this moving forward again?

PerryAJ avatar Mar 20 '19 23:03 PerryAJ

@PerryAJ It's a great question! The main blocking factor, other than time, is actually trying to setup a testing environment so we can have some confidence in this, and better confidence with changes going forward. I was hoping to setup at least a Storybook (https://storybook.js.org/) for it, with snapshot testing being ideal but I actually couldn't get this to work with Typescript. Anyway, if that was solved then we'd build out a set of examples to exercise as much of the existing functionality as possible. Honestly this library has enough complexity that any other approach is going to lead to a large number of regressions. Other than that, the work in this branch is in theory complete, though it would need updating to the latest typescript and likely fixing additional type errors, and bug fixes as they come up. I think if we got past the initial pain of setting the test environment though I can likely find some resources to help build tests (summer interns or whatever), or the community of users of this library could help too.

pjm17971 avatar Mar 23 '19 00:03 pjm17971