iperf icon indicating copy to clipboard operation
iperf copied to clipboard

Change displayed units to their correct form

Open AlbertBaubleDeem opened this issue 3 years ago • 1 comments

  • Version of iperf3 : master

  • Issues fixed (if any): This pull request changes second unit abbreviation sec to its SI symbol s. Further it fixes data-rate units to their correct form bits/sec to bit/s.

  • source: https://en.wikipedia.org/wiki/Data-rate_units

  • Brief description of code changes (suitable for use as a commit message): Change unit display sec -> s Change unit display bits/s -> bit/s

AlbertBaubleDeem avatar Oct 03 '22 02:10 AlbertBaubleDeem

Thanks for the PR! One difficulty with this change is that at least some of the formatting lines you've changed are parts of tables, and the changes disrupt the table formatting. One possible fix is to change "sec" to "s " so that the new labels take the same amount of space as the old ones. Also there are some merge conflicts because the code has diverged somewhat from when you submitted the PR. Any chance of fixing these up? We'll do a better job of reviewing.

bmah888 avatar Aug 03 '23 20:08 bmah888