obsidian-rtl icon indicating copy to clipboard operation
obsidian-rtl copied to clipboard

The folding symbol covers the first letter

Open osman1963 opened this issue 3 years ago • 6 comments

First of all, thanks for the awesome plugin. Second, I noticed that the folding symbol, that little inverted triangle, covers the first letter of the header when the direction is RTL. This wasn't the case before the advent of the new editor, nor is it when the direction is LTR. Thanks in advance and have a good day.

osman1963 avatar Jan 11 '22 10:01 osman1963

Fixing this in a reasonably robust way (i.e. something that won't break every theme) has proven much harder than I anticipated. Will continue to work on it soon enough and get it fixed.

esm7 avatar Jan 30 '22 20:01 esm7

That's great, thanks a lot. Are there some themes that don't have that issue? if so please let us know which ones. thanks again for your great plugin

osman1963 avatar Mar 26 '22 01:03 osman1963

I don't know, the only workaround I'm currently aware of is to not use folds. This issue is still around the top of my list, I just couldn't find the time in the past weeks :(

esm7 avatar Mar 29 '22 09:03 esm7

This is more or less fixed in the just-released 0.3.0 version, but I couldn't get it perfect yet. The fold symbol no longer covers the text, but it is not clickable in RTL.

esm7 avatar Jul 17 '22 17:07 esm7

Thank you so much for your effort and commitment. Good thing it doesn't cover the text now. Hope it works perfectly as you (and I) hope soon. I'll try changing the direction of text each time I want to click the fold then, and see how it goes. Thanks again and keep it up :)

On Sun, Jul 17, 2022 at 7:34 PM esm7 @.***> wrote:

This is more or less fixed in the just-released 0.3.0 version, but I couldn't get it perfect yet. The fold symbol no longer covers the text, but it is not clickable in RTL.

— Reply to this email directly, view it on GitHub https://github.com/esm7/obsidian-rtl/issues/29#issuecomment-1186577653, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARFSMS5YC7MTFYSKDVIJHRLVUQ7Z3ANCNFSM5LV52OIQ . You are receiving this because you authored the thread.Message ID: @.***>

osman1963 avatar Jul 17 '22 19:07 osman1963

Good News.. It is clickable. I just installed the update. It works fine and is clickable. The only minor thing, is what happen when you change themes. Once you change the theme the symbol reappears on the heading. Once you change direction to LTR, then back to RTL, it'll appear in the right place, and everything works just fine.

Thanks for the great work.

On Sun, Jul 17, 2022 at 9:18 PM Osman Moustafa < @.***> wrote:

Thank you so much for your effort and commitment. Good thing it doesn't cover the text now. Hope it works perfectly as you (and I) hope soon. I'll try changing the direction of text each time I want to click the fold then, and see how it goes. Thanks again and keep it up :)

On Sun, Jul 17, 2022 at 7:34 PM esm7 @.***> wrote:

This is more or less fixed in the just-released 0.3.0 version, but I couldn't get it perfect yet. The fold symbol no longer covers the text, but it is not clickable in RTL.

— Reply to this email directly, view it on GitHub https://github.com/esm7/obsidian-rtl/issues/29#issuecomment-1186577653, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARFSMS5YC7MTFYSKDVIJHRLVUQ7Z3ANCNFSM5LV52OIQ . You are receiving this because you authored the thread.Message ID: @.***>

osman1963 avatar Jul 18 '22 02:07 osman1963