Convert into monorepo

[nzakas]

trafficstars

In our discussion of how to move forward with incorporating all of the JS-related packages into a single repo the vote was clear: people prefer a monorepo with individual packages.

Rather than creating a new repo and moving everything into that, I propose that we repurpose the Espree repo as a monorepo containing all of the JS-related packages. Because Espree is the one where we do the most work and have the most history, this seems like a good way to retain the package history while still moving us forward.

Here are the transition steps I have in mind.

Steps

• [ ] Move all Espree-specific files into packages/espree
• [ ] Update release-please configuration to be a monorepo setup (like `eslint/rewrite)
• [ ] Update root README so it's not Espree-specific
• [ ] Update issue templates to indicate which package an issue is for
• [ ] Move eslint-scope from its own repo into packages/eslint-scope and update release-please
• [ ] Move eslint-visitor-keys from its own repo into packages/eslint-visitor-keys and update release-please

Later Steps

After that, it would be nice to get the packages transitioned to ESM and type checking, but that can be done incrementally.

Note: I'm looking for volunteers to do this as I already have too much on my plate.

[snitin315]

I'll work on it.

[nzakas]

@snitin315 we still need this accepted by the TSC, so please hold off for now.

[nzakas]

@eslint/eslint-tsc still looking for feedback here.

[fasttime]

Sounds good to me 👍🏻 This will allow all three packages to share the same tooling so it should simplify maintenance.

[mdjermanovic]

Sounds good to me too 👍

[mdjermanovic]

it would be nice to get the packages transitioned to ESM

All three packages are already ESM. In that regard, a difference between these and eslint/rewrite packages is only that in these packages we're publishing ESM source code as-is (all files), whereas in eslint/rewrite packages we're publishing an ESM bundle.

[nzakas]

All three packages are already ESM. In that regard, a difference between these and eslint/rewrite packages is only that in these packages we're publishing ESM source code as-is (all files), whereas in eslint/rewrite packages we're publishing an ESM bundle.

Ah, didn't realize everything was in ESM already.

In rewrite, I'm bundling first to avoid tsc creating a new .d.ts file for every file in src (which just seems like a better way to do things). We can do that in this repo as a follow-on step.

@snitin315 this is ready for you. 🎉

[nzakas]

@snitin315 are you still planning on working on this?

[snitin315]

@nzakas yes, I've made some progress locally will open a PR soon.

[aladdin-add]

We also need to rename the repo to something like eslint/js, but there is already an npm package called @eslint/js which can be confusing.😖

does it make sense to also moving @eslint/js to here?

[nzakas]

does it make sense to also moving @eslint/js to here?

Eventually, yes, but that will be a lot of work. So we'll have to live with the confusion for a while.

[aladdin-add]

@nzakas I've added a new step: "rename the repo to eslint/js, and update all links", just in case we forget about it. :)

[nzakas]

Renamed :+1:

[snitin315]

Is there anything remaining for this issue?

[aladdin-add]

I think no. but want @nzakas to verify.

[nzakas]

Looks like we got it all. Thanks @snitin315! 🙏