eslint icon indicating copy to clipboard operation
eslint copied to clipboard

refactor: Drop dependency on `text-table` to improve performance

Open jonkoops opened this issue 1 year ago • 6 comments

jonkoops avatar Jul 26 '24 15:07 jonkoops

Deploy Preview for docs-eslint canceled.

Name Link
Latest commit 88f64dafe3eb4b13baf156f8789f4248ba16ad0b
Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/66a3bd50249f920008f56f10

netlify[bot] avatar Jul 26 '24 15:07 netlify[bot]

I thought I opened this up on my fork, got some more enhancements coming up so I'll convert this to a draft.

jonkoops avatar Jul 27 '24 22:07 jonkoops

I know this is a wip, but since this is a performance optimization, could you please provide a comparison of performance data before and after the change when it's done so that team members can evaluate it, thank you!🙏

aladdin-add avatar Aug 06 '24 05:08 aladdin-add

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

github-actions[bot] avatar Aug 18 '24 22:08 github-actions[bot]

@aladdin-add we're just looking at removing a dependency, so perf isn't the key factor here.

nzakas avatar Aug 19 '24 15:08 nzakas

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

github-actions[bot] avatar Aug 29 '24 22:08 github-actions[bot]

I am closing this PR as it was never my intention to raise it at this early stage. I'll close it until I can come back with a final solution.

jonkoops avatar Aug 30 '24 16:08 jonkoops