eslint
fix: style issues in no-js mode
Prerequisites checklist
- [x] I have read the contributing guidelines.
What is the purpose of this pull request?
There are some styles that are different in no-js mode as compared enabled javascript mode.
What changes did you make? (Give an overview)
This PR fixes following style in no-js mode.
| JavaScript Enabled | JavaScript Disabled |
|---|---|
Related Issues
Is there anything you'd like reviewers to focus on?
Deploy Preview for new-eslint ready!
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 34736e4013eea79dfdff0028dfb05e0e66e2402f |
| Latest deploy log | https://app.netlify.com/sites/new-eslint/deploys/672c6f835415940008556fb6 |
| Deploy Preview | https://deploy-preview-628--new-eslint.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for hi-eslint ready!
| Name | Link |
|---|---|
| Latest commit | 34736e4013eea79dfdff0028dfb05e0e66e2402f |
| Latest deploy log | https://app.netlify.com/sites/hi-eslint/deploys/672c6f834d8e1900083592fd |
| Deploy Preview | https://deploy-preview-628--hi-eslint.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for es-eslint ready!
| Name | Link |
|---|---|
| Latest commit | 34736e4013eea79dfdff0028dfb05e0e66e2402f |
| Latest deploy log | https://app.netlify.com/sites/es-eslint/deploys/672c6f831b10db0008477433 |
| Deploy Preview | https://deploy-preview-628--es-eslint.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for fr-eslint ready!
| Name | Link |
|---|---|
| Latest commit | 34736e4013eea79dfdff0028dfb05e0e66e2402f |
| Latest deploy log | https://app.netlify.com/sites/fr-eslint/deploys/672c6f83ffe8cc0008b8cbf9 |
| Deploy Preview | https://deploy-preview-628--fr-eslint.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for ja-eslint ready!
| Name | Link |
|---|---|
| Latest commit | 34736e4013eea79dfdff0028dfb05e0e66e2402f |
| Latest deploy log | https://app.netlify.com/sites/ja-eslint/deploys/672c6f8326dd0d00083ff886 |
| Deploy Preview | https://deploy-preview-628--ja-eslint.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for zh-hans-eslint ready!
| Name | Link |
|---|---|
| Latest commit | 34736e4013eea79dfdff0028dfb05e0e66e2402f |
| Latest deploy log | https://app.netlify.com/sites/zh-hans-eslint/deploys/672c6f83f1637d00088a4a4e |
| Deploy Preview | https://deploy-preview-628--zh-hans-eslint.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for de-eslint ready!
| Name | Link |
|---|---|
| Latest commit | 34736e4013eea79dfdff0028dfb05e0e66e2402f |
| Latest deploy log | https://app.netlify.com/sites/de-eslint/deploys/672c6f838e3f0f0008f57bfe |
| Deploy Preview | https://deploy-preview-628--de-eslint.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for pt-br-eslint ready!
| Name | Link |
|---|---|
| Latest commit | 34736e4013eea79dfdff0028dfb05e0e66e2402f |
| Latest deploy log | https://app.netlify.com/sites/pt-br-eslint/deploys/672c6f8300d6c000084cdbb5 |
| Deploy Preview | https://deploy-preview-628--pt-br-eslint.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
A few issues still need to be addressed:
- On the donation page, the GitHub company logo is not visible in the "Ways to Sponsor" section when using dark theme in no-JS mode.
- Need to correct the styling for the code blocks.
In the light theme ESLint logo is not visible
I could not reproduce this, can you please share if it is in js or no-js mode, or any steps to reproduce?
In the light theme ESLint logo is not visible
I could not reproduce this, can you please share if it is in js or no-js mode, or any steps to reproduce?
I can reproduce this issue locally. you can check this preview link in the no-js mode light theme the ESlint logo is not visible.
@Tanujkanti4441 Hey can you this pr once I checked it looks like all of the issues are fixed.
We still have font-weight related issues as https://github.com/eslint/eslint/pull/18916 PR
I can see this isn't working? 🤔 IG this is powered by css / scripts from the other repo? so its fine?
Which page? can u add the URL too?
I can see this isn't working? 🤔 IG this is powered by css / scripts from the other repo? so its fine?
I think it's the getting started page of docs and this is not the part of eslint.org repo that is already fixed in https://github.com/eslint/eslint/pull/18916 PR.