eslint.org
eslint.org copied to clipboard
eslint
feat: add EOF banner
Prerequisites checklist
- [x] I have read the contributing guidelines.
What is the purpose of this pull request?
What changes did you make? (Give an overview)
Added EOL banner. (Addressed point no. 1 https://github.com/eslint/eslint.org/issues/594#issuecomment-2243119666)
| Desktop | Mobile |
|---|---|
Related Issues
https://github.com/eslint/eslint.org/issues/594
Is there anything you'd like reviewers to focus on?
- banner colour option selection for both dark and light themes.
- which link should be associated with the "long-term support" option text?
Deploy Preview for new-eslint ready!
| Name | Link |
|---|---|
| Latest commit | c93192c805eef1ac90f3fdce49485f4d55a7064c |
| Latest deploy log | https://app.netlify.com/sites/new-eslint/deploys/66b0e5b556f2d90008d84ae7 |
| Deploy Preview | https://deploy-preview-609--new-eslint.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for es-eslint ready!
| Name | Link |
|---|---|
| Latest commit | c93192c805eef1ac90f3fdce49485f4d55a7064c |
| Latest deploy log | https://app.netlify.com/sites/es-eslint/deploys/66b0e5b5c4c04a00092ec396 |
| Deploy Preview | https://deploy-preview-609--es-eslint.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for zh-hans-eslint ready!
| Name | Link |
|---|---|
| Latest commit | c93192c805eef1ac90f3fdce49485f4d55a7064c |
| Latest deploy log | https://app.netlify.com/sites/zh-hans-eslint/deploys/66b0e5b540f2470008bb5d1a |
| Deploy Preview | https://deploy-preview-609--zh-hans-eslint.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for ja-eslint ready!
| Name | Link |
|---|---|
| Latest commit | c93192c805eef1ac90f3fdce49485f4d55a7064c |
| Latest deploy log | https://app.netlify.com/sites/ja-eslint/deploys/66b0e5b5b6ee570008924540 |
| Deploy Preview | https://deploy-preview-609--ja-eslint.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for fr-eslint ready!
| Name | Link |
|---|---|
| Latest commit | c93192c805eef1ac90f3fdce49485f4d55a7064c |
| Latest deploy log | https://app.netlify.com/sites/fr-eslint/deploys/66b0e5b5267456000832fb8d |
| Deploy Preview | https://deploy-preview-609--fr-eslint.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for hi-eslint ready!
| Name | Link |
|---|---|
| Latest commit | c93192c805eef1ac90f3fdce49485f4d55a7064c |
| Latest deploy log | https://app.netlify.com/sites/hi-eslint/deploys/66b0e5b5ba57f60008c008fa |
| Deploy Preview | https://deploy-preview-609--hi-eslint.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for de-eslint ready!
| Name | Link |
|---|---|
| Latest commit | c93192c805eef1ac90f3fdce49485f4d55a7064c |
| Latest deploy log | https://app.netlify.com/sites/de-eslint/deploys/66b0e5b57dbbb6000885cc50 |
| Deploy Preview | https://deploy-preview-609--de-eslint.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for pt-br-eslint ready!
| Name | Link |
|---|---|
| Latest commit | c93192c805eef1ac90f3fdce49485f4d55a7064c |
| Latest deploy log | https://app.netlify.com/sites/pt-br-eslint/deploys/66b0e5b53370dc0008038dcd |
| Deploy Preview | https://deploy-preview-609--pt-br-eslint.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Thanks for putting this together. It looks like the hourglass is aligned to the text baseline, but it should be vertically centered in the banner. It appears there may be some extra space at the bottom of the hour glass?
We had decided not to use the bright purple banner as it was too aggressive. We were going to use the gray in option 1 of this comment.
"Long-term support options" should link to /version-support.
I would also adjust the text in the banner to read:
ESLint v8.x end-of-life is 2024-10-05 and will not be maintained after that. Upgrade or consider long-term support options.
