eslint-github-bot icon indicating copy to clipboard operation
eslint-github-bot copied to clipboard

Published 20 hours ago • verified publisher icon eslint

"Ready to merge" bugs

Open not-an-aardvark opened this issue 7 years ago • 2 comments

I think the "ready to merge" plugin has a few issues:

  • It gets triggered by a single status check changing on a PR, even if there are multiple status checks. So if a status check fails, and then a different status check passes, it will add the label.
  • It will respond to any approval review, even a review that isn't from a team member
  • Also, the three concerns from https://github.com/eslint/eslint-github-bot/issues/3#issuecomment-313953429

not-an-aardvark avatar Oct 17 '17 00:10 not-an-aardvark

This plugin is already disabled.

gyandeeps avatar Oct 17 '17 14:10 gyandeeps

Fair enough -- I'm just bringing these up in case we decide to enable it in the future.

not-an-aardvark avatar Oct 17 '17 16:10 not-an-aardvark