eslint-github-bot icon indicating copy to clipboard operation
eslint-github-bot copied to clipboard

Published 20 hours ago • verified publisher icon eslint

fix: revert node v20 & upgrade deps

Open aladdin-add opened this issue 1 year ago • 3 comments

it reverts the following commits:

  • 76601d6841784ee0b8cbe461bc1a9aa7282a97c4
  • 9c480a283e58f64d2fc7428d6428c657634b54e4
  • 4a5cccd74370bb46e841b3c498ef23b3e6ba551d

it reopens the issue: https://github.com/eslint/eslint-github-bot/issues/205

fixes https://github.com/eslint/eslint-github-bot/issues/212

aladdin-add avatar May 17 '24 02:05 aladdin-add

It looks like the changes are going in the reverse of what we want? Can you double check the diff?

nzakas avatar May 17 '24 14:05 nzakas

If the goal is to get back to b818e1bac3a60209ea7c10041e4f40c53db07e4c, there are still a lot of changes left (git diff b818e1b..4b444f8)

For example, CI is still testing on Node 20.

mdjermanovic avatar May 17 '24 14:05 mdjermanovic

I think the problem is that this branch starts from https://github.com/eslint/eslint-github-bot/commit/b818e1bac3a60209ea7c10041e4f40c53db07e4c.

Maybe the following could help:

$ git checkout issue212
$ git reset main --hard
$ git revert HEAD~3..HEAD

mdjermanovic avatar May 17 '24 16:05 mdjermanovic