eslint-github-bot
eslint-github-bot copied to clipboard
eslint
Auto-close should also close appropriate PRs
Currently auto-close only closes issue, however, if the issue was created to just be a front for the PR, that leaves PR orphan and make it harder to track. Examples are here: https://github.com/eslint/eslint/pull/11184 and https://github.com/eslint/eslint/pull/11186
What about if a PR is created to resolve multiple issues?
Could this cause more problems for us if an issue and PR are closed simultaneously, but then we decide to reopen the issue manually? We might forget the PR, and unlike what happened today, the PR would be in a closed state instead of open and would probably be forgotten about.
I think it might be better to instead have a scheduled task that looks at open PRs, and if all would-be-fixed/would-be-closed issues (so not just references to other issues) are closed, then the PR is closed. And ideally, the bot would require that issues are closed for a couple of days, to avoid those cases where the closure wasn't intended (i.e., if an issue is closed for a couple of days, it probably won't be reopened). Just my two cents.
I'm not sure I'd want to autoclose the PRs in this case. Maybe if we just left a comment on the PRs that the issue has been auto closed that would be enough to get someone to review it and determine if the PR should be closed too?
On Fri, Feb 1, 2019 at 11:10 AM Kevin Partington [email protected] wrote:
What about if a PR is created to resolve multiple issues?
Could this cause more problems for us if an issue and PR are closed simultaneously, but then we decide to reopen the issue manually? We might forget the PR, and unlike what happened today, the PR would be in a closed state instead of open and would probably be forgotten about.
I think it might be better to instead have a scheduled task that looks at open PRs, and if all would-be-fixed/would-be-closed issues (so not just references to other issues) are closed, then the PR is closed. And ideally, the bot would require that issues are closed for a couple of days, to avoid those cases where the closure wasn't intended (i.e., if an issue is closed for a couple of days, it probably won't be reopened). Just my two cents.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/eslint/eslint-github-bot/issues/103#issuecomment-459834078, or mute the thread https://github.com/notifications/unsubscribe-auth/AACWkpFJoz7pRJxqv3OpC9s3DTHERNUzks5vJJEzgaJpZM4aeyxx .
--
Nicholas C. Zakas @slicknet
Author, Principles of Object-Oriented JavaScript http://amzn.to/29Pmfrm Author, Understanding ECMAScript 6 http://amzn.to/29K1mIy
Sure, leaving a comment is fine by me. As long as there's some indication that the issue has been closed due to inactivity, it would help triage PRs.