create-config icon indicating copy to clipboard operation
create-config copied to clipboard

feat: support workspaces

Open WataruNishimura opened this issue 10 months ago • 4 comments

Relative issues

#96 (I submitted this issue)

What I did

  • Implementing findPnpmWorkspaceYaml() to find pnpm-workspace.yaml
    • if pnpm finds this, pnpm recognize as workspace root the directory even the file is empy.
  • Implementing passing pnpm workspace option -w to installSyncSaveDev()
    • Simple ternaly operator implemention.

WataruNishimura avatar Apr 17 '24 17:04 WataruNishimura

Hi @WataruNishimura!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

eslint-github-bot[bot] avatar Apr 17 '24 17:04 eslint-github-bot[bot]

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: WataruNishimura / name: Nishimura Wataru (52d4de23ed2827df3557280e6d0788f8ef1a1f27, f47dc3bde20892b675babebc2b17251fd9bf8c48, cba9611983ae243d216a7d08042bb39436d2e572, 3125b9627143b38dcd5a9a90b605f0b693778863, 51606aa969a7db194d186bc24a0dd2e53dcaf677, 44c27351c8d462f0c5d31ebcb9c6a1b255537b4c)

I think it should be a new feat: support workspaces, than a bugfix.

can you also add support for npm/yarn/bun?

Thanks for comments!

Sure I'll try it.

WataruNishimura avatar Apr 18 '24 03:04 WataruNishimura

@WataruNishimura are you still working on this?

aladdin-add avatar Jun 17 '24 08:06 aladdin-add

Closing because there hasn't been activity for 30 days. If you're still interested in submitting this code, please feel free to resubmit.

aladdin-add avatar Aug 15 '24 04:08 aladdin-add