eslint-plugin-promise icon indicating copy to clipboard operation
eslint-plugin-promise copied to clipboard

Published 20 hours ago • verified publisher icon eslint-community

add TypeScript declaration file

Open brettz9 opened this issue 1 year ago • 6 comments
trafficstars

Description

Add a TypeScript declaration file.

Steps to Reproduce

  1. Add import promise from 'eslint-plugin-promise'
  2. Hover over eslint-plugin-promise in VSC

Expected behavior: [What you expect to happen]

Get no errors.

Actual behavior: [What actually happens]

Get errors in VSC about TS types

brettz9 avatar Jul 19 '24 22:07 brettz9

Should we go all in with checkJs: true, basically going full JavaScript+JSDoc-as-TypeScript?

brettz9 avatar Jul 19 '24 23:07 brettz9

Real life example from neostandard: https://github.com/neostandard/neostandard/blob/08ae5469c71def357f0202fed2be9b83f62efc5a/lib/configs/base.js#L5

Should we go all in with checkJs: true, basically going full JavaScript+JSDoc-as-TypeScript?

I have a PR for that in another project, so I’m +1 on it

voxpelli avatar Jul 19 '24 23:07 voxpelli

Will probably wait on #484 to begin any work here, as don't want the tooling to have to be outdated to be supported...

brettz9 avatar Jul 20 '24 12:07 brettz9

Agree @brettz9 👍 And I think @scagood is also interested in this topic :)

voxpelli avatar Jul 20 '24 12:07 voxpelli

What is the status of this work? Is it still being considered or will it not be added at this time?

rgant avatar Feb 18 '25 22:02 rgant

Or even better: rewrite with TypeScript.

JounQin avatar May 18 '25 10:05 JounQin

What is the status of this work? Is it still being considered or will it not be added at this time?

Curious about this too.

Nick2bad4u avatar Jul 21 '25 05:07 Nick2bad4u