eslint-plugin-promise icon indicating copy to clipboard operation
eslint-plugin-promise copied to clipboard

fix(no-callback-in-promise): false positives when the exception is an argument

Open ahce opened this issue 2 years ago • 2 comments
trafficstars

What is the purpose of this pull request?

  • [ ] Documentation update
  • [x] Bug fix
  • [ ] New rule
  • [x] Changes an existing rule
  • [ ] Add autofixing to a rule
  • [ ] Other, please explain:

What changes did you make?

Fixes false positives when the exception is an argument of the promise call expression.

image

ahce avatar Aug 26 '23 23:08 ahce

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (bbcfcbf) to head (79d8d0d). Report is 7 commits behind head on main.

:exclamation: Current head 79d8d0d differs from pull request most recent head 98cf8d9

Please upload reports for the commit 98cf8d9 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #446   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines          649       646    -3     
  Branches       250       246    -4     
=========================================
- Hits           649       646    -3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 27 '23 13:08 codecov[bot]

@MichaelDeBoey any chance to merge this? 🙏

ahce avatar Oct 16 '23 23:10 ahce