eslint-plugin-promise
eslint-plugin-promise copied to clipboard
chore: prettier all files with lint-staged
Run for all files in lint-staged, and check on CI through lint
What is the purpose of this pull request?
- [ ] Documentation update
- [ ] Bug fix
- [ ] New rule
- [ ] Changes an existing rule
- [ ] Add autofixing to a rule
- [x] Other, please explain:
What changes did you make? (Give an overview)
This LGTM... Are we ok to move forward on it, @xjamundx if the conflicts are resolved?
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
bbcfcbf) to head (6cfa642). Report is 37 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #241 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 649 687 +38
Branches 250 260 +10
=========================================
+ Hits 649 687 +38
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Especially a non-breaking change like this can be merged once we have eg two reviews or one review and opportunity has been clearly given for others to voice their opinions :)
Maybe you could also put the mention of 2 reviews in the governance doc if that's the approach?
Especially a non-breaking change like this can be merged once we have eg two reviews or one review and opportunity has been clearly given for others to voice their opinions :)
Maybe you could also put the mention of 2 reviews in the governance doc if that's the approach?
Its a good idea, but I'm not sure we have enough consencus to get that in yet, its more of a general rule of thumb I would say