eslint-plugin-promise icon indicating copy to clipboard operation
eslint-plugin-promise copied to clipboard

chore: prettier all files with lint-staged

Open nschonni opened this issue 3 years ago • 4 comments
trafficstars

Run for all files in lint-staged, and check on CI through lint

What is the purpose of this pull request?

  • [ ] Documentation update
  • [ ] Bug fix
  • [ ] New rule
  • [ ] Changes an existing rule
  • [ ] Add autofixing to a rule
  • [x] Other, please explain:

What changes did you make? (Give an overview)

nschonni avatar Dec 18 '21 00:12 nschonni

This LGTM... Are we ok to move forward on it, @xjamundx if the conflicts are resolved?

brettz9 avatar Jul 19 '24 09:07 brettz9

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (bbcfcbf) to head (6cfa642). Report is 37 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #241   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines          649       687   +38     
  Branches       250       260   +10     
=========================================
+ Hits           649       687   +38     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 19 '24 16:07 codecov[bot]

Especially a non-breaking change like this can be merged once we have eg two reviews or one review and opportunity has been clearly given for others to voice their opinions :)

Maybe you could also put the mention of 2 reviews in the governance doc if that's the approach?

brettz9 avatar Jul 21 '24 23:07 brettz9

Especially a non-breaking change like this can be merged once we have eg two reviews or one review and opportunity has been clearly given for others to voice their opinions :)

Maybe you could also put the mention of 2 reviews in the governance doc if that's the approach?

Its a good idea, but I'm not sure we have enough consencus to get that in yet, its more of a general rule of thumb I would say

voxpelli avatar Jul 24 '24 09:07 voxpelli