eslint-plugin-promise icon indicating copy to clipboard operation
eslint-plugin-promise copied to clipboard

chore: put `__tests__/.eslintrc.json` in root's config's `override`

Open nschonni opened this issue 3 years ago • 2 comments
trafficstars

What is the purpose of this pull request?

  • [ ] Documentation update
  • [ ] Bug fix
  • [ ] New rule
  • [ ] Changes an existing rule
  • [ ] Add autofixing to a rule
  • [x] Other, please explain:

What changes did you make? (Give an overview) Merged up the nested ESLint config to an override in the root one

nschonni avatar Dec 18 '21 00:12 nschonni

Tell me more about why this is better. The old way made sense to me. This also seems fine. Just wondering if there's a big benefit.

xjamundx avatar Dec 18 '21 05:12 xjamundx

Yeah, either way is fine. Using the single file, you get to see all the rules and overrides in a single location when you want to add/remove plug-ins

nschonni avatar Dec 18 '21 06:12 nschonni

Something like this will need to be done when we adapt to flat config anyway, but I think it's better to focus on that rather than do this now that flat configs are the future

voxpelli avatar Jul 19 '24 22:07 voxpelli

And FWIW, FWICT, with flat configs at least, the "overrides" equivalent does not wipe out the whole property.

brettz9 avatar Jul 19 '24 22:07 brettz9