MongooseIM icon indicating copy to clipboard operation
MongooseIM copied to clipboard

remove pending subscriptions from state - they are retrieved anyway

Open bartekgorny opened this issue 5 years ago • 2 comments

bartekgorny avatar May 08 '20 08:05 bartekgorny

8229.1 / Erlang 22.0 / small_tests / 28ccb96e1087e53846e6eb5520d0887897019e67 Reports root / small


8229.2 / Erlang 22.0 / internal_mnesia / 28ccb96e1087e53846e6eb5520d0887897019e67 Reports root/ big OK: 1458 / Failed: 0 / User-skipped: 157 / Auto-skipped: 0


8229.4 / Erlang 22.0 / mysql_redis / 28ccb96e1087e53846e6eb5520d0887897019e67 Reports root/ big OK: 2682 / Failed: 0 / User-skipped: 213 / Auto-skipped: 0


8229.3 / Erlang 22.0 / odbc_mssql_mnesia / 28ccb96e1087e53846e6eb5520d0887897019e67 Reports root/ big OK: 2687 / Failed: 0 / User-skipped: 208 / Auto-skipped: 0


8229.5 / Erlang 22.0 / riak_mnesia / 28ccb96e1087e53846e6eb5520d0887897019e67 Reports root/ big OK: 1583 / Failed: 0 / User-skipped: 172 / Auto-skipped: 0


8229.6 / Erlang 22.0 / ldap_mnesia / 28ccb96e1087e53846e6eb5520d0887897019e67 Reports root/ big OK: 1366 / Failed: 0 / User-skipped: 249 / Auto-skipped: 0


8229.7 / Erlang 22.0 / elasticsearch_and_cassandra_mnesia / 28ccb96e1087e53846e6eb5520d0887897019e67 Reports root/ big OK: 328 / Failed: 0 / User-skipped: 28 / Auto-skipped: 0


8229.9 / Erlang 21.3 / pgsql_mnesia / 28ccb96e1087e53846e6eb5520d0887897019e67 Reports root/ big / small OK: 2700 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0

mongoose-im avatar May 08 '20 08:05 mongoose-im

Codecov Report

Merging #2734 into master will increase coverage by 1.73%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2734      +/-   ##
==========================================
+ Coverage   77.55%   79.29%   +1.73%     
==========================================
  Files         373      373              
  Lines       30538    30538              
==========================================
+ Hits        23685    24215     +530     
+ Misses       6853     6323     -530     
Impacted Files Coverage Δ
src/ejabberd_c2s.erl 89.28% <100.00%> (+0.24%) :arrow_up:
src/event_pusher/mod_event_pusher_sns.erl 85.13% <0.00%> (-5.41%) :arrow_down:
src/mam/mod_mam_rdbms_prefs.erl 92.59% <0.00%> (-3.71%) :arrow_down:
src/rdbms/mongoose_rdbms.erl 70.40% <0.00%> (-2.05%) :arrow_down:
...bal_distrib/mod_global_distrib_hosts_refresher.erl 75.51% <0.00%> (-2.05%) :arrow_down:
src/ejabberd_local.erl 72.18% <0.00%> (-1.51%) :arrow_down:
src/mam/mod_mam_utils.erl 83.49% <0.00%> (-0.67%) :arrow_down:
src/mod_muc_room.erl 77.35% <0.00%> (-0.30%) :arrow_down:
src/pubsub/mod_pubsub.erl 72.28% <0.00%> (-0.18%) :arrow_down:
src/mod_muc_log.erl 77.69% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0e3b372...13d82d1. Read the comment docs.

codecov[bot] avatar May 08 '20 09:05 codecov[bot]

Closing this one and the subsequent two PRs because most of this work was already done in the latest mongoose_c2s rework. Only wonder if anything else is on these PRs that wasn't done in such rework, if so please open an issue or let me know to keep note of it 🙂

NelsonVides avatar Nov 13 '23 18:11 NelsonVides