Underscores are not a valid part of a domain name, so they are safe to replace dots to in the metric name (i.e. this can't lead to a collision with an existing host name).

Replacing dots with underscores prevents hosts from being treated as multiple separate metrics nodes e.g. by Graphite and Grafana.

Aug 08 '18 13:08 kzemek

5360.1 / Erlang 19.3 / small_tests / c09f1a8bd24cb110f5374802f593412984ef0772 Reports root / small

5360.3 / Erlang 19.3 / mysql_redis / c09f1a8bd24cb110f5374802f593412984ef0772 Reports root/ big OK: 2821 / Failed: 0 / User-skipped: 222 / Auto-skipped: 0

5360.2 / Erlang 19.3 / internal_mnesia / c09f1a8bd24cb110f5374802f593412984ef0772 Reports root/ big OK: 1067 / Failed: 0 / User-skipped: 45 / Auto-skipped: 0

5360.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / c09f1a8bd24cb110f5374802f593412984ef0772 Reports root/ big OK: 445 / Failed: 0 / User-skipped: 8 / Auto-skipped: 0

5360.5 / Erlang 19.3 / ldap_mnesia / c09f1a8bd24cb110f5374802f593412984ef0772 Reports root/ big OK: 1031 / Failed: 0 / User-skipped: 81 / Auto-skipped: 0

5360.4 / Erlang 19.3 / odbc_mssql_mnesia / c09f1a8bd24cb110f5374802f593412984ef0772 Reports root/ big OK: 2835 / Failed: 0 / User-skipped: 208 / Auto-skipped: 0

5360.8 / Erlang 20.0 / pgsql_mnesia / c09f1a8bd24cb110f5374802f593412984ef0772 Reports root/ big / small OK: 2867 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0

5360.9 / Erlang 21.0 / riak_mnesia / c09f1a8bd24cb110f5374802f593412984ef0772 Reports root/ big / small OK: 1290 / Failed: 0 / User-skipped: 43 / Auto-skipped: 0

Aug 08 '18 13:08 mongoose-im

Codecov Report

Merging #2025 into master will increase coverage by 0.09%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2025      +/-   ##
==========================================
+ Coverage   74.92%   75.02%   +0.09%     
==========================================
  Files         314      314              
  Lines       28619    28621       +2     
==========================================
+ Hits        21444    21472      +28     
+ Misses       7175     7149      -26

Impacted Files	Coverage Δ
src/mongoose_metrics.erl	`92.59% <100.00%> (+0.11%)`	:arrow_up:
..._distrib/mod_global_distrib_outgoing_conns_sup.erl	`73.91% <0.00%> (-8.70%)`	:arrow_down:
...rc/global_distrib/mod_global_distrib_transport.erl	`47.05% <0.00%> (-5.89%)`	:arrow_down:
src/mod_muc_log.erl	`77.69% <0.00%> (ø)`
src/pubsub/mod_pubsub.erl	`66.18% <0.00%> (+0.18%)`	:arrow_up:
src/ejabberd_c2s.erl	`84.88% <0.00%> (+0.36%)`	:arrow_up:
src/mod_muc_room.erl	`77.24% <0.00%> (+0.76%)`	:arrow_up:
src/mod_bosh_socket.erl	`81.66% <0.00%> (+1.00%)`	:arrow_up:
src/global_distrib/mod_global_distrib_utils.erl	`80.80% <0.00%> (+1.01%)`	:arrow_up:
src/muc_light/mod_muc_light_utils.erl	`85.26% <0.00%> (+1.05%)`	:arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f9029a1...fdf98fd. Read the comment docs.

Aug 08 '18 14:08 codecov[bot]

5361.1 / Erlang 19.3 / small_tests / da2b9ddcb518118504d56a8df8fe13ccb59d516f Reports root / small

5361.3 / Erlang 19.3 / mysql_redis / da2b9ddcb518118504d56a8df8fe13ccb59d516f Reports root/ big OK: 2821 / Failed: 0 / User-skipped: 222 / Auto-skipped: 0

5361.2 / Erlang 19.3 / internal_mnesia / da2b9ddcb518118504d56a8df8fe13ccb59d516f Reports root/ big OK: 1067 / Failed: 0 / User-skipped: 45 / Auto-skipped: 0

5361.4 / Erlang 19.3 / odbc_mssql_mnesia / da2b9ddcb518118504d56a8df8fe13ccb59d516f Reports root/ big OK: 2835 / Failed: 0 / User-skipped: 208 / Auto-skipped: 0

5361.5 / Erlang 19.3 / ldap_mnesia / da2b9ddcb518118504d56a8df8fe13ccb59d516f Reports root/ big OK: 1031 / Failed: 0 / User-skipped: 81 / Auto-skipped: 0

5361.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / da2b9ddcb518118504d56a8df8fe13ccb59d516f Reports root/ big OK: 445 / Failed: 0 / User-skipped: 8 / Auto-skipped: 0

5361.8 / Erlang 20.0 / pgsql_mnesia / da2b9ddcb518118504d56a8df8fe13ccb59d516f Reports root/ big / small OK: 2867 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0

5361.9 / Erlang 21.0 / riak_mnesia / da2b9ddcb518118504d56a8df8fe13ccb59d516f Reports root/ big / small OK: 1290 / Failed: 0 / User-skipped: 43 / Auto-skipped: 0

Aug 08 '18 15:08 mongoose-im

@kzemek, @fenek: Have you progressed on this PR?

Sep 21 '21 01:09 Neustradamus

Replace dots in "host" part of metric name with underscores.

Codecov Report