rc-knob icon indicating copy to clipboard operation
rc-knob copied to clipboard

how l can disable events on Knob?

Open matador96 opened this issue 5 years ago • 2 comments

Hello, how l can disable any events (like onClick or onKeyDown) on Knob?

matador96 avatar Jul 26 '20 14:07 matador96

Mhmm, that's something I've overlooked yet. But in the end it's easy as all it needs is a disabled flag that will prevent the adding of the events to the outer div. Do you feel comfortable to open an PR for it or should I do it, but I'm not sure when I will find time for it.

eskimoblood avatar Jul 26 '20 19:07 eskimoblood

Mhmm, that's something I've overlooked yet. But in the end it's easy as all it needs is a disabled flag that will prevent the adding of the events to the outer div. Do you feel comfortable to open an PR for it or should I do it, but I'm not sure when I will find time for it.

Yeah, l know that, but l think maybe have default functions or props for this.

Thanks for answer ;)

matador96 avatar Jul 27 '20 01:07 matador96