/corporations/{corporation_id}/customs_offices/ doesn't return Customs Offices within Planetary Skyhooks

[weeeeems]

Feature Request

When requesting Corporation Customs Offices only Orbital Customs Offices are shown, and not the Customs Offices within Orbital Skyhooks. They should be included either here (makes most sense) or on the Structures endpoint.

Use case

Corporation and alliance leaders, third party apps, the unpaid IT nerds critical to the running of any large group.

We use first and third party tools to monitor our structures and ensure things like access and taxes are aligned. This is not easily done even in the ingame client (hundreds of clicks). This is already available for existing Customs Offices so seems like this was just missed when adding Orbital Skyhooks.

Authentication

Does this feature require a new scope, an existing scope, or no scope? E.g.:

Existing scope esi-planets.read_customs_offices.v1

Example return

Propose what an example return might look like. E.g.:

Should make no difference if its an Orbital Skyhooks or Customs Office. The only difference would be a wider reinforce_exit_end and reinforce_exit_start which would easily identify it as a Skyhook.

[
  {
    "alliance_tax_rate": 0.019999999552965164,
    "allow_access_with_standings": true,
    "allow_alliance_access": true,
    "bad_standing_tax_rate": 0.10000000149011612,
    "corporation_tax_rate": 0.019999999552965164,
    "excellent_standing_tax_rate": 0.019999999552965164,
    "good_standing_tax_rate": 0.019999999552965164,
    "neutral_standing_tax_rate": 0.10000000149011612,
    "office_id": {office_id},
    "reinforce_exit_end": 14,
    "reinforce_exit_start": 10,
    "standing_level": "terrible",
    "system_id": {system_id},
    "terrible_standing_tax_rate": 0.10000000149011612
  },
  ...
]

Checklist

Check all boxes that apply to this issue:

• [X] Feature request description is provided
• [X] Use case exists
• [ ] Feature requires a new route
• [X] Feature adds data to existing route
• [ ] Feature requires new auth scope
• [X] Feature can reuse existing scope
• [ ] Feature does not require auth
• [ ] Meta feature, applies to all routes

[soratidus999]

Thankyou for documenting this, this was raised with CCP and CSM day 4-5 of equinox. But i did not have skyhooks or pocos to show example returns for the data

[ccp-pinky]

This should be fixed since the Legion expansion. Would you be able to confirm that for us?

[soratidus999]

I am not seeing any POCO's in my DB still, I will need to check the returns to be sure

[ccp-pinky]

Please do, as if I create a Skyhook, it is showing up under the route in the URL just fine. If that isn't working for you, we will have to do some digging :)

[soratidus999]

This endpoint is working as intended, We are struggling to match these office_id's against corp assets causing our issues.

adjacent, but unrelated.

[pvyParts]

Bit more data from my debugging, as Ariel stated the endpoint is now returning spec valid data for skyhooks.

Previously due to there not being a planet_id in the returned data ( #1050 noted in here ) we were using the /corporations/{corporation_id}/assets/names/ endpoint to figure out what planet they belonged to, so we didn't have to do math, that doesn't work any more as it just returns an empty string for the name.

However the /corporations/{corporation_id}/assets/locations/ does work so you can do some math and find the closest celestial and figure out the planet that way.

[ccp-pinky]

In that case, closing up the ticket!

If you feel that the empty asset name is a bug, please make sure there is either an issue or please create one!

I appreciate the validation this is now working! Tnx all!