NPC standing changes in character notifications endpoints is always NPCStandingsLost

[evanova]

Bug

When getting character notifications, the changes of standings on a NPC is always NPCStandingsLost even with positive gain which is expected to be set as NPCStandingsGained according to the ESI API.

This was reported by a user and I verified this by running some agent missions and check my notifications.

Request

GET /latest/characters/{character_id}/notifications?datasource=tranquility

Response

200

Status Code

N/A

Headers

N/A

Body

The second entry is (I think) a gain by completing a mission. Unfortunately, the text is rather cryptic and can't be used to infer if it's actually a gain or loss to work around this.

  {
    "notification_id": 1656727635,
    "sender_id": 500010,
    "sender_type": "faction",
    "text": "- - 500010\n  - 599400461\n  - -0.03\n  - -1.0\n  - 1.0\n  - -1.1251429381079856\n",
    "timestamp": "2022-09-17T15:53:00Z",
    "type": "NPCStandingsLost"
  },
  {
    "notification_id": 1656723856,
    "sender_id": 3018935,
    "sender_type": "character",
    "text": "- - 3018935\n  - 599400461\n  - 0.095625\n  - -1.0\n  - 1.0\n  - 6.898370374702953\n- - 1000167\n  - 599400461\n  - 0.008196429\n  - -1.0\n  - 1.0\n",
    "timestamp": "2022-09-17T15:44:00Z",
    "type": "NPCStandingsLost"
  },

Expected

"type": "NPCStandingsGained" for the second entry above.

Checklist

Check all boxes that apply to this issue:

• [X] Bug description is provided
• [X] Request path is provided
• [X] Response status code is provided
• [X] Response headers are provided
• [X] Response body is provided
• [X] Expected response is provided