esi-issues icon indicating copy to clipboard operation
esi-issues copied to clipboard

ship_type_id in Bloodlines is nullable

Open joaomlneto opened this issue 3 years ago • 0 comments

Inconsistency

The ship_type_id field in the /universe/bloodlines is marked as required, but the retrieved data may be null.

The spec guarantees correctness by providing a x-nullable attribute to the field in the spec.

This is not consistent with other parts of the API, where the semantics are to omit the field from the results (at least from what I've observed). I've been only recently experimenting with mostly the Universe API for fun; feel free to correct me!

Resolution

  • Mark the field ship_type_id as not required
  • Do not return the field for cases where it is null

Checklist

Check all boxes that apply to this issue:

joaomlneto avatar Aug 17 '22 00:08 joaomlneto