esi-issues icon indicating copy to clipboard operation
esi-issues copied to clipboard

characters/{character_id}/assets returns unspecified 404

Open wvdvegt opened this issue 5 years ago • 1 comments

Bug

After a number of pages, get_characters_character_id_assets returns

{"error":"Undefined 404 response. Original message: Requested page does not exist!"}

This response code is however not specified in the swagger definition.

Request

https://esi.evetech.net/dev/characters/{character_id}/assets/

Response

Status Code

404

Headers

Body

{"error":"Undefined 404 response. Original message: Requested page does not exist!"}

Expected

Should be specified in the swagger definition. Seems a request beyond the last page.

Checklist

Check all boxes that apply to this issue:

  • [x] Bug description is provided
  • [x] Request path is provided
  • [x] Response status code is provided
  • [ ] Response headers are provided
  • [x] Response body is provided
  • [x] Expected response is provided

wvdvegt avatar Dec 02 '20 12:12 wvdvegt

This should be updated in the Swagger docs to specify this. However this isn't a bug per-say. The solution is to do pagination properly. See https://developers.eveonline.com/blog/article/esi-concurrent-programming-and-pagination.

Blacksmoke16 avatar Dec 02 '20 21:12 Blacksmoke16