esi-issues icon indicating copy to clipboard operation
esi-issues copied to clipboard

ESS Escow Payment missing in corporations/{corporation_id}/wallets/{division}/journal

Open SvenBrnn opened this issue 4 years ago • 3 comments

Bug

When calling the corporations/{corporation_id}/wallets/{division}/journal/ ESI API the JSON returned does not give out payments of type ESS Escow Payment (By corp Tax).

Request

GET corporations/{corporation_id}/wallets/{division}/journal/?datasource=tranquility

Status Code

200

Headers

Include relevant headers received. Timestamps and request ID is nice, you may not have all these values, fill out what you received (don't worry about headers not listed here, unless pertinent to your issue). E.g.:

 access-control-allow-credentials: true  access-control-allow-headers: Content-Type,Authorization,If-None-Match,X-User-Agent  access-control-allow-methods: GET,HEAD,OPTIONS  access-control-allow-origin: *  access-control-expose-headers: Content-Type,Warning,ETag,X-Pages,X-ESI-Error-Limit-Remain,X-ESI-Error-Limit-Reset  access-control-max-age: 600  allow: GET,HEAD,OPTIONS  cache-control: private  content-encoding: gzip  content-type: application/json; charset=UTF-8  date: Sat, 21 Nov 2020 09:57:20 GMT  etag: "58c798a793ad0ed030274ee2bc6a0bc9ad88fe67a1e88602ffa4cde3"  expires: Sat, 21 Nov 2020 10:57:19 GMT  last-modified: Sat, 21 Nov 2020 09:57:19 GMT  strict-transport-security: max-age=31536000  vary: Accept-Encoding  x-esi-error-limit-remain: 100  x-esi-error-limit-reset: 40  x-esi-request-id: 84ef990f-3265-4c2b-8e05-18b19a4bb025  x-firefox-spdy: h2  x-pages: 2 

Body

Please provide the response body, feel free to scrub any opsec details you wish. E.g.:

[
  {
    "amount": 167190.83,
    "balance": 3547621034.3574,
    "context_id": 30005125,
    "context_id_type": "system_id",
    "date": "2020-11-20T21:44:39Z",
    "description": "xxx got bounty prizes for killing pirates in xxx",
    "first_party_id": xxx,
    "id": xxx,
    "reason": "18564: 3,18073: 2,18074: 3,18075: 3,18077: 1,18078: 2,18082: 5,3747: 2,18084: 5,18085: 7,18086: 5,23476: 2,23477: 3,23478: 4,23479: 2",
    "ref_type": "bounty_prizes",
    "second_party_id": 95114065,
    "tax": 167190.82649977354,
    "tax_receiver_id": xxx
  },
  {
    "amount": 173250,
    "balance": 3545036470.2074,
    "date": "2020-11-20T16:52:54Z",
    "description": "Reward given for scientific contribution to Project Discovery.",
    "first_party_id": xxx,
    "id": xxx,
    "reason": "",
    "ref_type": "project_discovery_reward",
    "second_party_id": xxx
  }
]

Expected

It was espected for the JSON to contain 3 ESS Escow Payment's between the two entries. grafik

Checklist

Check all boxes that apply to this issue:

  • [x] Bug description is provided
  • [x] Request path is provided
  • [x] Response status code is provided
  • [x] Response headers are provided
  • [x] Response body is provided
  • [x] Expected response is provided

SvenBrnn avatar Nov 21 '20 10:11 SvenBrnn

Internal issue TTC-3853 has been created.

mateuszkrasucki avatar Nov 24 '20 11:11 mateuszkrasucki

This looks like it's been fixed at some point. Here's a corporate wallet journal ESI row retrieved today:

{
	"amount":19795.13, 
	"balance":27872322836.3622, 
	"context_id":30005123, 
	"date":"2021-01-16T20:02:11Z", 
	"description":"Encounter Surveillance System in H-29TM transferred funds to Toeasy", 
	"first_party_id":1000132, 
	"id":18895616204, 
	"reason":"", 
	"ref_type":"ess_escrow_transfer", 
	"second_party_id":1022672447
}

What I can't find is the equivalent record in the character wallet journal. I'll go hunting further in the issues DB to see if there's an issue for that created already.

Eingang avatar Feb 09 '21 19:02 Eingang

@mateuszkrasucki Seems this is still an issue but for the char endpoint only.

Blacksmoke16 avatar Aug 17 '21 00:08 Blacksmoke16

Going to close this in favor of #1345 given it seems to be resolved for the corp endpoint.

Blacksmoke16 avatar Feb 20 '23 14:02 Blacksmoke16