esi-issues icon indicating copy to clipboard operation
esi-issues copied to clipboard

NPC PVE kill wallet jounal entries even if they give no bounty

Open streamgamelabels opened this issue 4 years ago • 1 comments

Feature Request

I would love to be able to track more PVE data in the sandbox. Currently I use wallet entries to track PVE kills. But this only lists entities that generated bounty payout. I would love for a way to track also the ships that did not generate bounty.

Use case

People interested in pure PVE statistics, in my specific use case it would be to expand the stats I deliver to those consuming my type of data with more analysis on what they are fighting in their PVE encounters.

Authentication

This feature could done by adding all PVE kills to existing endpoints like it already does with those generating bounty payments in Wallet Journal Entries, if no ship at all generates payout then a 0 isk wallet entry that just lists the ships in "reason" in the existing fashion would be sufficient.

Example return

Propose what an example return might look like. E.g.:

  {
    "amount": 0,
    "balance": 274085721.2565,
    "context_id": 32000127,
    "context_id_type": "system_id",
    "date": "2020-07-05T11:57:49Z",
    "description": "Player got bounty prizes for killing pirates in Bynshe",
    "first_party_id": 1000125,
    "id": 18205292448,
    "reason": "52207: 2,48091: 3,48090: 3",
    "ref_type": "bounty_prizes",
    "second_party_id": 1234567891
  },

Checklist

Check all boxes that apply to this issue:

  • [x] Feature request description is provided
  • [x] Use case exists
  • [ ] Feature requires a new route
  • [x] Feature adds data to existing route
  • [ ] Feature requires new auth scope
  • [x] Feature can reuse existing scope
  • [ ] Feature does not require auth
  • [ ] Meta feature, applies to all routes

streamgamelabels avatar Jul 07 '20 11:07 streamgamelabels

that should be another endpoint, eg activities/{userid}/pve/kills/{systemid}/{day} returning for each entity id the number of entity killed.

with activities/{userid}/pve/kills/ listing all the (systemid,day)couples that can be used.

guiguilechat avatar Jul 07 '20 12:07 guiguilechat