Character Contract Bids endpoint return HTTP 500

[warlof]

Bug

When requesting contract bids from an auction type contract, I receive an unexpected 500 error.

Request

GET /latest/characters/90633617/contracts/124758629/bids/?datasource=tranquility

Response

Status Code

500

Headers

Date: Thu, 09 Apr 2020 14:12:00 GMT
X-ESI-Request-ID: 6c50fbd6-0150-4a17-b4c4-d850e6f354e1 

Body

{
  "error": "Unhandled internal error encountered!"
}

Expected

Status Code

200

Body

[
    {
        "amount": 4646548.54,
        "bid_id": 65465431,
        "bidder_id": 90479794,
        "date_bid": "2017-11-20T13:17:34Z"
    }
]

Checklist

Check all boxes that apply to this issue:

• [x] Bug description is provided
• [x] Request path is provided
• [x] Response status code is provided
• [x] Response headers are provided
• [x] Response body is provided
• [x] Expected response is provided

[GoldenGnu]

Could it be that you’re trying to request a deleted contract? You have never been able to get contract details for deleted contracts.

[warlof]

It's difficult to say, according to database, it's a contract with status finished. However, the entry is 3 years old, so could it be the reason ?

If that's the case, we should get a 400 or a 404. At least, something more meaningful.

[gitAskur]

Very likely from internal cleanup like @warlof suggests, and should return a meaningful status code and not cause internal errors.