israeli-bank-scrapers icon indicating copy to clipboard operation
israeli-bank-scrapers copied to clipboard

feat(mizrahi): scrape extra info

Open simonlsk opened this issue 3 months ago • 4 comments

Fix #784.

Changes:

  • Extract Cookie from main page request.
  • Fetch extra details request (endpoint /Online/api/OSH/getMaherBerurimSMF) if additionalTransactionInformation is true.
  • Concatenate details in txn.memo in the format field1: value1; field2: value2; ...;

Status and todos:

  • [x] Tests passing locally.
  • [ ] Not sure about the returned memo format.
  • [ ] Check if there is a cleaner way to extract the cookie and use it in my requests.
  • [ ] Not stressed tested on many transactions.

I don't have a lot of experience with puppeteer, would love to get some inputs about the unchecked boxes.

Thanks

simonlsk avatar Nov 22 '24 22:11 simonlsk