israeli-bank-scrapers icon indicating copy to clipboard operation
israeli-bank-scrapers copied to clipboard

Hapoalim scraper gets only the first 150 transactions

Open skoant opened this issue 2 years ago • 2 comments

skoant avatar Oct 26 '22 17:10 skoant

Hi @skoant checking the code base I see it has a magic number 150 which explain why you get only up to 150 numItemsPerPage=150

https://github.com/eshaham/israeli-bank-scrapers/blob/81aed787a263a658180a819aa7b2354a1b6203e4/src/scrapers/hapoalim.ts#L141

as it is there since long time ago, and as I don't have hapoalim account, I don't know it is like that because of a concrete reason. Feel free to adjust the number locally and test it (follow this guide).

If it works with larger number just create a PR and I'll merge it.

esakal avatar Oct 30 '22 10:10 esakal

Hi @esakal, Thanks for looking into it. Please see my PR fixing this issue BR

skoant avatar Nov 09 '22 19:11 skoant

The mentioned PR was merged a few weeks ago.

esakal avatar Dec 25 '22 13:12 esakal