israeli-bank-scrapers
israeli-bank-scrapers copied to clipboard
Future (Abroad) transactions to be processed in future months are missing in visaCal
Hi, So this is not a new issue (for me) but it annoyed me enough to raise it here and maybe to finally solve it :)
In visa cal when you "show transactions by process date" you can't choose a future month later than the next immediate month (i.e the latest is October when i'm viewing my transactions in Sep)
Since my abroad transactions are processed two months later (Sep transactions will only be visible in December, same as July transactions are only visible in October)
As you can see using the "show transactions by processed date" option, there is no way to view the abroad transactions I did on August and September...
But... using the "show transactions by transaction date option" I can see abroad transactions BUT not the installment transactions 🤦
@esakal what do you say we extend the scraper to scrape transactions using the "show transactions by transaction date option" in addition to the "show transactions by processed date" and then deduplicate the transactions? that way we'll at least see the whole picture...
Other suggestions?
Hi @erikash sorry that it took me that long to reply.
I'm familiar with the missing installment transactions when using process dates. I actually tried to implement the scraper originally with the process date and switched eventually to process date.
We have in options the property futureMonthsToScrape
that is used already in max, amex and isracard. It sounds like you can extend the visa scraper like you suggested to consolidate information from both processed date and transaction date.
I'm not sure if the best approach would be to:
- scrape all the installments like today by processed date.
- scrape all other transactions by transaction date
Or to deduplicate the transactions like you mentioned.
Both should work, the second is more closer to what we do today while the first sounds more robust assuming that only installments are missing. So I'm ok with both by favor a bit the second one.
what do you think?
Thanks Eran, Now It's my turn to be a bit busy...
Hope to have some time to work on this next week :)
Happy holidays! Erik.
On Mon, Sep 26, 2022 at 9:46 PM Eran Sakal @.***> wrote:
Hi @erikash https://github.com/erikash sorry that it took me that long to reply.
I'm familiar with the missing installment transactions when using process dates. I actually tried to implement the scraper originally with the process date and switched eventually to process date.
We have in options the property futureMonthsToScrape that is used already in max, amex and isracard. It sounds like you can extend the visa scraper like you suggested to consolidate information from both processed date and transaction date.
I'm not sure if the best approach would be to:
- scrape all the installments like today by processed date.
- scrape all other transactions by transaction date
Or to deduplicate the transactions like you mentioned.
Both should work, the second is more closer to what we do today while the first sounds more robust assuming that only installments are missing. So I'm ok with both by favor a bit the second one.
what do you think?
— Reply to this email directly, view it on GitHub https://github.com/eshaham/israeli-bank-scrapers/issues/721#issuecomment-1258460766, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABCIPKORGTEU7OM2XZYKGTWAHVQVANCNFSM6AAAAAAQOOYXZM . You are receiving this because you were mentioned.Message ID: @.***>
Didn't have much time.. but I really liked your two step approach @esakal without deduplication (except for the combined installment transaction maybe?).
Hope to get to this next Saturday 🙏
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
setting enableTransactionsFilterByDate
to false should resolve this
Congrats @orzarchi - your PR https://github.com/eshaham/israeli-bank-scrapers/pull/777 seems to solve this issue as well :)