Ensar Sarajčić
Ensar Sarajčić
This was very weird to fix. I managed to get it to work by returning that original `IntervalStream` to the `Utilization` wrapper and just polling it and ignoring its results....
Hi @pront , does this look alright? Does it need further changes? My latest change has fixed issues with tests, but it is not ideal 😄
> > Hi @pront , does this look alright? Does it need further changes? My latest change has fixed issues with tests, but it is not ideal 😄 > >...
Checks passed locally. Not sure why the spelling check failed, it seems like it is in some other files.
> How did you verify this change locally? I wanted to run my own set of tests as well before we merge this one Hmm I can't find my exact...
I have tested it with this now: ```yaml api: enabled: true sources: internal_metrics_1: type: internal_metrics http: type: http_server address: 0.0.0.0:59001 encoding: "text" headers: - User-Agent transforms: filter_utilization: type: filter inputs:...
> I'm trying to run your config from both `master` and your branch and then checking for changes. I'm seeing utilization metrics coming through for `"component_id":"console_http"` in both versions and...
> > > I'm trying to run your config from both `master` and your branch and then checking for changes. I'm seeing utilization metrics coming through for `"component_id":"console_http"` in both...
@pront this is still not done (I need to implement filtering by tags and maybe aggregation too), but I wanted to check if the way this global metrics cache is...
@pront Just checking if you had time to look at this one.