John Linhart

Results 551 comments of John Linhart

This proves the point that unit tests are useless. Let's not write them anymore especially with dealing with DB queries. Let's write functional tests instead, please. We use the code...

That is true, but it could be fixed by a migration or even one time update query. At least for the unique counts.

The fix https://github.com/mautic/mautic/pull/13915 was merged and will be released in Mautic 5.1.1. I'm closing this issue now.

The server_version issue was reported back for M4 too: https://forum.mautic.org/t/error-when-running-any-console-command-like-php-bin-console-cache-clear/30307 This PR could be related: https://github.com/mautic/mautic/pull/9739

Are you sure you've provided correct database credentials? Can you connect with those credentials from other tool like Sequel Pro for example?

There is no ETA as volunteers have limited time to work on this. But may I ask why would you prefer to use Mysqli over PDO?

@omert37 can you please check the Mautic logs to see what exactly is the problem with your instance?

@andersonjeccel this is failing CI on open PRs with ``` The configuration file (path: .github/labeler.yml) is found locally, reading from the file ``` Example: https://github.com/mautic/mautic/pull/13990/checks Do you want to quickly...

Reverted in https://github.com/mautic/mautic/pull/13993