John Linhart
John Linhart
@volha-pivavarchyk this is decreasing the test coverage. Please write a test for it.
Thanks for attacking this problem! I think it is wrong fix though. From my experience users hate if something modifies the content they write. Wouldn't be better to fix the...
Are you saying that the email queue does not work at all? That it will send the email only to 1 contact? I can't imagine crucial feature would be broken...
Please rebase the PR on top of 5.x branch and if you want to back-port it to the last Mautic 4 release(s) then create a duplicate PR against the 4.4...
Ah, however, this will need a rebase. The 4.x branch is dead. There won't be any feature M4 releases anymore. Please rebase on 5.x branch and if you need this...
I have also fixed this bug in our fork recently. It's slightly different solution. I'd like to avoid conflicts. I cannot push it directly as it depends on other PR...
@volha-pivavarchyk this is our version of the same bug fix. Please take a look: https://github.com/mautic/mautic/pull/11443
@RCheesley I'm not clear whether you approve or block merging this PR. @npracht can you please resolve the conflict and create a duplicate PR for the 5.x branch, please?
I cannot find where is the property used. I can find that the StepInterface and EmailStep are used during the installation. Is that where you get the error? Or what...
@kuzmany did I understand correctly that we can close this one as https://github.com/mautic/mautic/pull/11457#issuecomment-1242049375 fixes the same issue?